From: Bjorn Helgaas <helgaas@kernel.org>
To: Luo Yifan <luoyifan@cmss.chinamobile.com>
Cc: manivannan.sadhasivam@linaro.org, kw@linux.com,
kishon@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools: PCI: Fix several incorrect format specifiers
Date: Wed, 20 Nov 2024 14:22:16 -0600 [thread overview]
Message-ID: <20241120202216.GA2347727@bhelgaas> (raw)
In-Reply-To: <20241112090924.287056-1-luoyifan@cmss.chinamobile.com>
On Tue, Nov 12, 2024 at 05:09:24PM +0800, Luo Yifan wrote:
> Make a minor change to eliminate static checker warnings. Fix several
> incorrect format specifiers that misused signed and unsigned versions.
>
> Signed-off-by: Luo Yifan <luoyifan@cmss.chinamobile.com>
Applied with Mani's reviewed-by to pci/misc for v6.13, thanks!
> ---
> tools/pci/pcitest.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
> index 470258009..7b530d838 100644
> --- a/tools/pci/pcitest.c
> +++ b/tools/pci/pcitest.c
> @@ -95,7 +95,7 @@ static int run_test(struct pci_test *test)
>
> if (test->msinum > 0 && test->msinum <= 32) {
> ret = ioctl(fd, PCITEST_MSI, test->msinum);
> - fprintf(stdout, "MSI%d:\t\t", test->msinum);
> + fprintf(stdout, "MSI%u:\t\t", test->msinum);
> if (ret < 0)
> fprintf(stdout, "TEST FAILED\n");
> else
> @@ -104,7 +104,7 @@ static int run_test(struct pci_test *test)
>
> if (test->msixnum > 0 && test->msixnum <= 2048) {
> ret = ioctl(fd, PCITEST_MSIX, test->msixnum);
> - fprintf(stdout, "MSI-X%d:\t\t", test->msixnum);
> + fprintf(stdout, "MSI-X%u:\t\t", test->msixnum);
> if (ret < 0)
> fprintf(stdout, "TEST FAILED\n");
> else
> @@ -116,7 +116,7 @@ static int run_test(struct pci_test *test)
> if (test->use_dma)
> param.flags = PCITEST_FLAGS_USE_DMA;
> ret = ioctl(fd, PCITEST_WRITE, ¶m);
> - fprintf(stdout, "WRITE (%7ld bytes):\t\t", test->size);
> + fprintf(stdout, "WRITE (%7lu bytes):\t\t", test->size);
> if (ret < 0)
> fprintf(stdout, "TEST FAILED\n");
> else
> @@ -128,7 +128,7 @@ static int run_test(struct pci_test *test)
> if (test->use_dma)
> param.flags = PCITEST_FLAGS_USE_DMA;
> ret = ioctl(fd, PCITEST_READ, ¶m);
> - fprintf(stdout, "READ (%7ld bytes):\t\t", test->size);
> + fprintf(stdout, "READ (%7lu bytes):\t\t", test->size);
> if (ret < 0)
> fprintf(stdout, "TEST FAILED\n");
> else
> @@ -140,7 +140,7 @@ static int run_test(struct pci_test *test)
> if (test->use_dma)
> param.flags = PCITEST_FLAGS_USE_DMA;
> ret = ioctl(fd, PCITEST_COPY, ¶m);
> - fprintf(stdout, "COPY (%7ld bytes):\t\t", test->size);
> + fprintf(stdout, "COPY (%7lu bytes):\t\t", test->size);
> if (ret < 0)
> fprintf(stdout, "TEST FAILED\n");
> else
> --
> 2.27.0
>
>
>
prev parent reply other threads:[~2024-11-20 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 9:09 [PATCH] tools: PCI: Fix several incorrect format specifiers Luo Yifan
2024-11-15 11:30 ` Manivannan Sadhasivam
2024-11-20 20:22 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241120202216.GA2347727@bhelgaas \
--to=helgaas@kernel.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=luoyifan@cmss.chinamobile.com \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox