From: Bjorn Helgaas <helgaas@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 11/15] PCI: don't include 'pm_wakeup.h' directly
Date: Wed, 20 Nov 2024 16:34:36 -0600 [thread overview]
Message-ID: <20241120223436.GA2358716@bhelgaas> (raw)
In-Reply-To: <20241118072917.3853-12-wsa+renesas@sang-engineering.com>
On Mon, Nov 18, 2024 at 08:29:10AM +0100, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
I plan to pick this up for v6.14 as soon as the v6.13 merge window
closes.
> ---
> drivers/pci/pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 225a6cd2e9ca..3b1939c9cf46 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -23,7 +23,6 @@
> #include <linux/string.h>
> #include <linux/log2.h>
> #include <linux/logic_pio.h>
> -#include <linux/pm_wakeup.h>
> #include <linux/device.h>
> #include <linux/pm_runtime.h>
> #include <linux/pci_hotplug.h>
> --
> 2.39.2
>
next prev parent reply other threads:[~2024-11-20 22:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 7:28 [PATCH 00/15] treewide: don't include 'pm_wakeup.h' directly Wolfram Sang
2024-11-18 7:29 ` [PATCH 11/15] PCI: " Wolfram Sang
2024-11-20 22:34 ` Bjorn Helgaas [this message]
2024-12-22 21:22 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241120223436.GA2358716@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox