From: Steven Rostedt <rostedt@goodmis.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: Shuai Xue <xueshuai@linux.alibaba.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
bhelgaas@google.com, tony.luck@intel.com, bp@alien8.de,
mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
oleg@redhat.com, naveen@kernel.org, davem@davemloft.net,
anil.s.keshavamurthy@intel.com, mark.rutland@arm.com,
peterz@infradead.org
Subject: Re: [PATCH v3] PCI: hotplug: Add a generic RAS tracepoint for hotplug event
Date: Thu, 21 Nov 2024 19:08:26 -0500 [thread overview]
Message-ID: <20241121190826.78506b40@gandalf.local.home> (raw)
In-Reply-To: <Zz-9vviSWP8oRPUx@wunner.de>
On Fri, 22 Nov 2024 00:09:50 +0100
Lukas Wunner <lukas@wunner.de> wrote:
> Would something like
>
> /sys/kernel/debug/tracing/events/pci/hotplug_event
>
> be possible? It would seem more elegant than
>
> /sys/kernel/debug/tracing/events/pci/pci_hp_event
>
> because it avoids the duplication of "pci" in the path.
Most events have the name of the system in it (see the sched events).
That's to prevent the duplicates in other places. Also, in the trace
output, only the event name is shown and not the system. That is, if you
have more than one "hotplug_event" enabled, the trace will not
differentiate them.
My suggestion is the "pci_hp_event" as it will be more obvious in the trace
output.
-- Steve
next prev parent reply other threads:[~2024-11-22 0:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 12:43 [PATCH v3] PCI: hotplug: Add a generic RAS tracepoint for hotplug event Shuai Xue
2024-11-21 9:27 ` Lukas Wunner
2024-11-21 11:34 ` Shuai Xue
2024-11-21 13:43 ` Steven Rostedt
2024-11-21 23:09 ` Lukas Wunner
2024-11-22 0:08 ` Steven Rostedt [this message]
2024-11-22 6:25 ` Shuai Xue
2024-11-22 10:29 ` Lukas Wunner
2024-11-22 1:53 ` Shuai Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241121190826.78506b40@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=naveen@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tony.luck@intel.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox