From: Niklas Cassel <cassel@kernel.org>
To: "Jesper Nilsson" <jesper.nilsson@axis.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Frank Li" <Frank.Li@nxp.com>, "Jon Mason" <jdmason@kudzu.us>
Cc: Damien Le Moal <dlemoal@kernel.org>,
Niklas Cassel <cassel@kernel.org>,
linux-arm-kernel@axis.com, linux-pci@vger.kernel.org
Subject: [PATCH v5 0/6] PCI endpoint additional pci_epc_set_bar() checks
Date: Wed, 27 Nov 2024 11:30:16 +0100 [thread overview]
Message-ID: <20241127103016.3481128-8-cassel@kernel.org> (raw)
Hello all,
This series adds some extra checks to ensure that it is not possible to
program the iATU with an address which we did not intend to use.
If these checks were in place when testing some of the earlier revisions
of Frank's doorbell patches (which did not handle fixed BARs properly),
we would gotten an error, rather than silently using an address which we
did not intend to use.
Having these checks in place will hopefully avoid similar debugging in the
future.
Kind regards,
Niklas
Changes since v4:
-Split patch 1/5 into two patches (patch 1/6 and 2/6), as suggested by Mani.
-Added Cc: stable for patch 1/6, as suggested by Mani.
-Picked up tags from Mani.
Niklas Cassel (6):
PCI: dwc: ep: iATU registers must be written after the BAR_MASK
PCI: dwc: ep: Add missing checks when dynamically changing a BAR
PCI: dwc: ep: Add 'address' alignment to 'size' check in
dw_pcie_prog_ep_inbound_atu()
PCI: artpec6: Implement dw_pcie_ep operation get_features
PCI: endpoint: Add size check for fixed size BARs in pci_epc_set_bar()
PCI: endpoint: Verify that requested BAR size is a power of two
drivers/pci/controller/dwc/pcie-artpec6.c | 13 +++++
.../pci/controller/dwc/pcie-designware-ep.c | 52 ++++++++++++++-----
drivers/pci/controller/dwc/pcie-designware.c | 5 +-
drivers/pci/controller/dwc/pcie-designware.h | 2 +-
drivers/pci/endpoint/pci-epc-core.c | 14 ++++-
5 files changed, 67 insertions(+), 19 deletions(-)
--
2.47.0
next reply other threads:[~2024-11-27 10:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 10:30 Niklas Cassel [this message]
2024-11-27 10:30 ` [PATCH v5 1/6] PCI: dwc: ep: iATU registers must be written after the BAR_MASK Niklas Cassel
2024-11-30 8:23 ` Manivannan Sadhasivam
2024-12-04 17:33 ` Bjorn Helgaas
2024-12-13 13:34 ` Niklas Cassel
2024-12-13 14:38 ` Niklas Cassel
2024-11-27 10:30 ` [PATCH v5 2/6] PCI: dwc: ep: Add missing checks when dynamically changing a BAR Niklas Cassel
2024-11-30 8:24 ` Manivannan Sadhasivam
2024-12-04 17:17 ` Bjorn Helgaas
2024-12-13 13:37 ` Niklas Cassel
2024-11-27 10:30 ` [PATCH v5 3/6] PCI: dwc: ep: Add 'address' alignment to 'size' check in dw_pcie_prog_ep_inbound_atu() Niklas Cassel
2024-11-27 10:30 ` [PATCH v5 4/6] PCI: artpec6: Implement dw_pcie_ep operation get_features Niklas Cassel
2024-11-27 10:30 ` [PATCH v5 5/6] PCI: endpoint: Add size check for fixed size BARs in pci_epc_set_bar() Niklas Cassel
2024-11-27 10:30 ` [PATCH v5 6/6] PCI: endpoint: Verify that requested BAR size is a power of two Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241127103016.3481128-8-cassel@kernel.org \
--to=cassel@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=dlemoal@kernel.org \
--cc=jdmason@kudzu.us \
--cc=jesper.nilsson@axis.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@axis.com \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox