Re: [PATCH v3 1/6] dt-bindings: PCI: Add binding for qps615

Krzysztof Kozlowski
2024-11-26T06:58:25Z

On 26/11/2024 07:50, Krishna Chaitanya Chundru wrote:
>
>
> On 11/25/2024 1:10 PM, Krzysztof Kozlowski wrote:
>> On 24/11/2024 02:41, Krishna Chaitanya Chundru wrote:
>>>> ...
>>>>
>>>>> + qps615,axi-clk-freq-hz:
>>>>
>>>> That's a downstream code you send us.
>>>>
>>>> Anyway, why assigned clock rates do not work for you? You are
>>>> re-implementing legacy property now under different name :/
>>>>
>>>> The assigned clock rates comes in to the picture when we are
>>>> using clock
>>> framework to control the clocks. For this switch there are no
>>> clocks needs to be control, the moment we power on the switch
>>> clocks are enabled by default. This switch provides a mechanism to
>>> control the frequency using i2c. And switch supports only two
>>> frequencies i.e
>>
>>
>> frequency of what, since there are no clocks?
>>
> The axi clock frequency internal to the switch, host can't control
> the enablement of the clocks it can control only the frequency.
>
> we already had a discussion on this on v2[1], and we taught you agreed
> on this property.
>
> [1]
> https://lore.kernel.org/netdev/d1af1eac-f9bd-7a8e-586b-5c2a76445145@codeaurora.org/T/#m3d5864c758f2e05fa15ba522aad6a37e3417bd9f
>

This points something else. I diged v2 and found many unanswered
questions and unfinished discussion:

https://lore.kernel.org/r/linux-arm-msm/20240803-qps615-v2-0-9560b7c71369@quicinc.com/T/#m7074ab9e5f89e29faf430c82f769e67d0e4072cf

The property description did not improve, actually it got worse: you
repeat constraints in free form text.

Best regards,
Krzysztof