Re: [PATCH v6 0/8] PCI: Consolidate TLP Log reading and printing

Ilpo Järvinen
2024-10-23T08:27:22Z

[-- Attachment #1: Type: text/plain, Size: 2322 bytes --]

On Fri, 13 Sep 2024, Ilpo Järvinen wrote:

> This series has the remaining patches of the AER & DPC TLP Log handling
> consolidation and now includes a few minor improvements to the earlier
> accepted TLP Logging code.
>
> v6:
> - Preserve "AER:"/"DPC:" prefix on the printed TLP line
> - New patch to add "AER:" also on other lines of the AER error dump

Hi Bjorn,

A small reminder this series exists.

--
i.

> v5:
> - Fix build with AER=y and DPC=n
> - Match kerneldoc and function parameter name
>
> v4:
> - Added patches:
> - Remove EXPORT of pcie_read_tlp_log()
> - Moved code to pcie/tlp.c and build only with AER enabled
> - Match variables in prototype and function
> - int -> unsigned int conversion
> - eetlp_prefix_max into own patch
> - struct pcie_tlp_log param consistently called "log" within tlp.c
> - Moved function prototypes into drivers/pci/pci.h
> - Describe AER/DPC differences more clearly in one commit message
>
> v3:
> - Small rewording in a commit message
>
> v2:
> - Don't add EXPORT()s
> - Don't include igxbe changes
> - Don't use pr_cont() as it's incompatible with pci_err() and according
> to Andy Shevchenko should not be used in the first place
>
> Ilpo Järvinen (8):
> PCI: Don't expose pcie_read_tlp_log() outside of PCI subsystem
> PCI: Move TLP Log handling to own file
> PCI: Make pcie_read_tlp_log() signature same
> PCI: Use unsigned int i in pcie_read_tlp_log()
> PCI: Store # of supported End-End TLP Prefixes
> PCI: Add TLP Prefix reading into pcie_read_tlp_log()
> PCI: Create helper to print TLP Header and Prefix Log
> PCI/AER: Add prefixes to printouts
>
> drivers/pci/ats.c | 2 +-
> drivers/pci/pci.c | 28 ---------
> drivers/pci/pci.h | 9 +++
> drivers/pci/pcie/Makefile | 2 +-
> drivers/pci/pcie/aer.c | 26 ++++----
> drivers/pci/pcie/dpc.c | 14 ++---
> drivers/pci/pcie/tlp.c | 109 ++++++++++++++++++++++++++++++++++
> drivers/pci/probe.c | 14 +++--
> include/linux/aer.h | 3 +-
> include/linux/pci.h | 2 +-
> include/uapi/linux/pci_regs.h | 2 +
> 11 files changed, 149 insertions(+), 62 deletions(-)
> create mode 100644 drivers/pci/pcie/tlp.c
>
>