Re: [PATCH v4 17/18] nvmet: New NVMe PCI endpoint target driver

Damien Le Moal
2024-12-14T05:52:23Z

On 12/13/24 03:55, Bjorn Helgaas wrote:
> On Thu, Dec 12, 2024 at 08:34:39PM +0900, Damien Le Moal wrote:
>
>> This ensure correct operation if, for instance, the host reboots
>> causing the PCI link to be temporarily down.
>
> s/ensure/ensures/
>
>> The configuration of a NVMe PCI endpoint controller is done using
>> configfgs. First the NVMe PCI target controller configuration must be
>> done to set up a subsystem and a port with the "pci" addr_trtype
>> attribute. The subsystem can be setup using a file or block device
>> backed namespace or using a passthrough NVMe device. After this, the
>> PCI endpoint can be configured and bound to the PCI endpoint controller
>> to start the NVMe endpoint controller.
>
> s/addr_trtype/addr_type/ ?

Nope, addr_trtype is correct. "address transport type" is the meaning for an
nvme target port.

> s/configfgs/configfs/

Good catch. Thanks.

--
Damien Le Moal
Western Digital Research