Re: [PATCH v4 13/18] nvmet: Implement host identifier set feature support

Bjorn Helgaas
2024-12-12T18:50:10Z

On Thu, Dec 12, 2024 at 08:34:35PM +0900, Damien Le Moal wrote:
> The NVMe specifications mandate support for the host identifier
> set_features for controllers that also supports reservations. Satisfy
> this requirement by implementing handling of the NVME_FEAT_HOST_ID
> feature for the nvme_set_features command. This implementation is for
> now effective only for PCI target controllers. For other controller
> types, the set features command is failed with a NVME_SC_CMD_SEQ_ERROR
> status as before.
>
> As noted in the code, 128 bits host identifiers are supported since the
> NVMe bass specifications version 2.1 indicate in section 5.1.25.1.28.1
> that "The controller may support a 64-bit Host Identifier...".

s/bass/base/