From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F11291D9592 for ; Thu, 12 Dec 2024 18:55:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734029729; cv=none; b=OrK7Xi1fXUr4lrSgiMkLqobbcECJTWDBS0+DkutGPUbFv0hvyc5sjY8zxO8vS2HpGEO6tTin7VVm8q3haOoj8JhDnH73iNKNheSPDhADiL0oQa1k7lps3Xixz3zBGEKB0SiuThnY13LgtAlK1A+V17iWLTJzAsvT1FwihpqPNSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734029729; c=relaxed/simple; bh=iC63c2TfMwutN6CHlOx6ciqpXlH4loUdJcyZovJHIwQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=IfVxn2KxHnFlrp4HQR3f+tq6/jQef7TA5o5v2DAHoarkgbM5eRQ9XMkIZzOMmZLJrM8iyTEqye/lol8w5DzvnIxAlseHJso2hWw/puyaEwb7AL/elT/YnKfd6/tYDDma+0zGVP1dQ+SBiokDZUshP/p8cyrVn9etsLHVm75JHbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CdLt3LRd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CdLt3LRd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43D4FC4CECE; Thu, 12 Dec 2024 18:55:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734029728; bh=iC63c2TfMwutN6CHlOx6ciqpXlH4loUdJcyZovJHIwQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=CdLt3LRdRxlehMKz4zIBkBo/OKzlURCHDEkmxHQDI5TfmgA6/hr1ZKA88Xblwa21h Q8c58GT5edDsbsKbt6R0IFL8giY0ocGxd9pWVDqmmgGdMLm1++IhD3Cd+uKBLeFQc8 T1WJq9ViN9YeD9hYvPRIOnKCI/GGIgAfDiKnQSvnQvLuXhZCSUfUNdHqtmlzZLL8NW qKu5iSVXt443Y+tO3x9+dw0q8gLgyjRZ75/SBJs5dgj/54YmLhsTxQOtQwTBjmtGp+ SDqYMmDn3Qe8d8WJPTvjzRJHzMLF80wtEw4CqQ9LEtd+08JwJQpeYNciACRbCbgQ+p 3soTaSulMEgEQ== Date: Thu, 12 Dec 2024 12:55:27 -0600 From: Bjorn Helgaas To: Damien Le Moal Cc: linux-nvme@lists.infradead.org, Christoph Hellwig , Keith Busch , Sagi Grimberg , linux-pci@vger.kernel.org, Manivannan Sadhasivam , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Lorenzo Pieralisi , Rick Wertenbroek , Niklas Cassel Subject: Re: [PATCH v4 17/18] nvmet: New NVMe PCI endpoint target driver Message-ID: <20241212185527.GA3356063@bhelgaas> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241212113440.352958-18-dlemoal@kernel.org> On Thu, Dec 12, 2024 at 08:34:39PM +0900, Damien Le Moal wrote: > This ensure correct operation if, for instance, the host reboots > causing the PCI link to be temporarily down. s/ensure/ensures/ > The configuration of a NVMe PCI endpoint controller is done using > configfgs. First the NVMe PCI target controller configuration must be > done to set up a subsystem and a port with the "pci" addr_trtype > attribute. The subsystem can be setup using a file or block device > backed namespace or using a passthrough NVMe device. After this, the > PCI endpoint can be configured and bound to the PCI endpoint controller > to start the NVMe endpoint controller. s/addr_trtype/addr_type/ ? s/configfgs/configfs/