From: Rob Herring <robh@kernel.org>
To: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
manivannan.sadhasivam@linaro.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
jingoohan1@gmail.com, michal.simek@amd.com,
bharat.kumar.gogada@amd.com
Subject: Re: [RESEND PATCH v5 1/3] dt-bindings: PCI: dwc: Add AMD Versal2 mdb slcr support
Date: Tue, 17 Dec 2024 09:00:58 -0600 [thread overview]
Message-ID: <20241217150058.GA1660852-robh@kernel.org> (raw)
In-Reply-To: <20241213064035.1427811-2-thippeswamy.havalige@amd.com>
On Fri, Dec 13, 2024 at 12:10:33PM +0530, Thippeswamy Havalige wrote:
> Add support for mdb slcr aperture that is only supported for AMD Versal2
> devices.
>
> Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
> ---
> Changes in v3:
> -------------
> - Introduced below changes in dwc yaml schema.
> Changes in v5:
> -------------
> - Modify mdb_pcie_slcr as constant.
> ---
> Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> index 548f59d76ef2..696568e81cfc 100644
> --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> @@ -113,6 +113,8 @@ properties:
> enum: [ smu, mpu ]
> - description: Tegra234 aperture
> enum: [ ecam ]
> + - description: AMD MDB PCIe slcr region
> + const: mdb_pcie_slcr
Including the block name is redundant. Just 'slcr' is sufficient.
> allOf:
> - contains:
> const: dbi
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-12-17 15:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 6:40 [RESEND PATCH v5 0/3] Add support for AMD MDB IP as Root Port Thippeswamy Havalige
2024-12-13 6:40 ` [RESEND PATCH v5 1/3] dt-bindings: PCI: dwc: Add AMD Versal2 mdb slcr support Thippeswamy Havalige
2024-12-17 15:00 ` Rob Herring [this message]
2024-12-18 9:30 ` Havalige, Thippeswamy
2024-12-13 6:40 ` [RESEND PATCH v5 2/3] dt-bindings: PCI: amd-mdb: Add AMD Versal2 MDB PCIe Root Port Bridge Thippeswamy Havalige
2024-12-17 15:10 ` Rob Herring
2024-12-18 9:28 ` Havalige, Thippeswamy
2025-01-02 20:55 ` Rob Herring
2024-12-13 6:40 ` [RESEND PATCH v5 3/3] PCI: amd-mdb: Add AMD MDB Root Port driver Thippeswamy Havalige
2024-12-13 17:27 ` Bjorn Helgaas
2024-12-17 10:16 ` Havalige, Thippeswamy
2024-12-13 8:55 ` [RESEND PATCH v5 0/3] Add support for AMD MDB IP as Root Port Krzysztof Kozlowski
2024-12-16 6:09 ` Havalige, Thippeswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241217150058.GA1660852-robh@kernel.org \
--to=robh@kernel.org \
--cc=bharat.kumar.gogada@amd.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=michal.simek@amd.com \
--cc=thippeswamy.havalige@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox