public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Jon Mason <jdmason@kudzu.us>, Frank Li <Frank.Li@nxp.com>,
	Damien Le Moal <dlemoal@kernel.org>,
	linux-arm-kernel@axis.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH v6 0/6] PCI endpoint additional pci_epc_set_bar() checks
Date: Thu, 19 Dec 2024 08:55:58 +0900	[thread overview]
Message-ID: <20241218235558.GD1444967@rocinante> (raw)
In-Reply-To: <20241213143301.4158431-8-cassel@kernel.org>

Hello,

> This series adds some extra checks to ensure that it is not possible to
> program the iATU with an address which we did not intend to use.
> 
> If these checks were in place when testing some of the earlier revisions
> of Frank's doorbell patches (which did not handle fixed BARs properly),
> we would gotten an error, rather than silently using an address which we
> did not intend to use.
> 
> Having these checks in place will hopefully avoid similar debugging in the
> future.

Applied to endpoint, thank you!

[01/06] PCI: dwc: ep: Write BAR_MASK before iATU registers in pci_epc_set_bar()
        https://git.kernel.org/pci/pci/c/33a6938e0c33

[02/06] PCI: dwc: ep: Prevent changing BAR size/flags in pci_epc_set_bar()
        https://git.kernel.org/pci/pci/c/3708acbd5f16

[03/06] PCI: dwc: ep: Add 'address' alignment to 'size' check in dw_pcie_prog_ep_inbound_atu()
        https://git.kernel.org/pci/pci/c/129f6af747b2

[04/06] PCI: artpec6: Implement dw_pcie_ep operation get_features
        https://git.kernel.org/pci/pci/c/b61fef0813cb

[05/06] PCI: endpoint: Add size check for fixed size BARs in pci_epc_set_bar()
        https://git.kernel.org/pci/pci/c/f015b53d634a

[06/06] PCI: endpoint: Verify that requested BAR size is a power of two
        https://git.kernel.org/pci/pci/c/0e7faea1880c

	Krzysztof

      parent reply	other threads:[~2024-12-18 23:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13 14:33 [PATCH v6 0/6] PCI endpoint additional pci_epc_set_bar() checks Niklas Cassel
2024-12-13 14:33 ` [PATCH v6 1/6] PCI: dwc: ep: Write BAR_MASK before iATU registers in pci_epc_set_bar() Niklas Cassel
2024-12-13 14:33 ` [PATCH v6 2/6] PCI: dwc: ep: Prevent changing BAR size/flags " Niklas Cassel
2024-12-13 14:33 ` [PATCH v6 3/6] PCI: dwc: ep: Add 'address' alignment to 'size' check in dw_pcie_prog_ep_inbound_atu() Niklas Cassel
2024-12-13 14:33 ` [PATCH v6 4/6] PCI: artpec6: Implement dw_pcie_ep operation get_features Niklas Cassel
2024-12-13 14:33 ` [PATCH v6 5/6] PCI: endpoint: Add size check for fixed size BARs in pci_epc_set_bar() Niklas Cassel
2024-12-13 14:33 ` [PATCH v6 6/6] PCI: endpoint: Verify that requested BAR size is a power of two Niklas Cassel
2024-12-18 23:55 ` Krzysztof Wilczyński [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241218235558.GD1444967@rocinante \
    --to=kw@linux.com \
    --cc=Frank.Li@nxp.com \
    --cc=bhelgaas@google.com \
    --cc=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=jdmason@kudzu.us \
    --cc=jesper.nilsson@axis.com \
    --cc=jingoohan1@gmail.com \
    --cc=kishon@kernel.org \
    --cc=linux-arm-kernel@axis.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox