From: Mohamed Khalfella <khalfella@gmail.com>
To: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Niklas Cassel" <cassel@kernel.org>,
"Frank Li" <Frank.Li@nxp.com>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Mohamed Khalfella" <khalfella@gmail.com>,
"Wang Jiang" <jiangwang@kylinos.cn>
Cc: "Krzysztof Wilczyński" <kwilczynski@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] PCI: endpoint: Set RX DMA channel to NULL aftre freeing it
Date: Fri, 20 Dec 2024 19:00:00 -0800 [thread overview]
Message-ID: <20241221030011.1360947-1-khalfella@gmail.com> (raw)
Fixed a small bug in pci-epf-test driver. When requesting TX DMA channel
fails, free already allocated RX channel and set it to NULL.
Fixes: 8353813c88ef ("PCI: endpoint: Enable DMA tests for endpoints with DMA capabilities")
Signed-off-by: Mohamed Khalfella <khalfella@gmail.com>
---
drivers/pci/endpoint/functions/pci-epf-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
index ef6677f34116..d90c8be7371e 100644
--- a/drivers/pci/endpoint/functions/pci-epf-test.c
+++ b/drivers/pci/endpoint/functions/pci-epf-test.c
@@ -251,7 +251,7 @@ static int pci_epf_test_init_dma_chan(struct pci_epf_test *epf_test)
fail_back_rx:
dma_release_channel(epf_test->dma_chan_rx);
- epf_test->dma_chan_tx = NULL;
+ epf_test->dma_chan_rx = NULL;
fail_back_tx:
dma_cap_zero(mask);
--
2.45.2
next reply other threads:[~2024-12-21 3:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-21 3:00 Mohamed Khalfella [this message]
2024-12-21 8:24 ` [PATCH] PCI: endpoint: Set RX DMA channel to NULL aftre freeing it Niklas Cassel
2024-12-21 17:34 ` [PATCH v2] PCI: endpoint: Set RX DMA channel to NULL after " Mohamed Khalfella
2024-12-26 16:31 ` Manivannan Sadhasivam
2024-12-26 17:51 ` Mohamed Khalfella
2024-12-27 13:59 ` Manivannan Sadhasivam
2024-12-27 16:08 ` [PATCH v3] PCI: endpoint: pci-epf-test: Fix NULL ptr assignment to dma_chan_rx Mohamed Khalfella
2024-12-30 7:26 ` Manivannan Sadhasivam
2024-12-30 18:36 ` Mohamed Khalfella
2025-01-15 11:25 ` Krzysztof Wilczyński
2024-12-21 19:18 ` [PATCH] PCI: endpoint: Set RX DMA channel to NULL aftre freeing it Markus Elfring
2024-12-21 20:00 ` Mohamed Khalfella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241221030011.1360947-1-khalfella@gmail.com \
--to=khalfella@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=jiangwang@kylinos.cn \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox