From: "Krzysztof Wilczyński" <kw@linux.com>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-pci@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Niklas Cassel <cassel@kernel.org>
Subject: Re: [PATCH v2] PCI: rockchip: Add missing fields descriptions for struct rockchip_pcie_ep
Date: Mon, 23 Dec 2024 06:12:50 +0900 [thread overview]
Message-ID: <20241222211250.GD3111282@rocinante> (raw)
In-Reply-To: <20241216133404.540736-1-dlemoal@kernel.org>
Hello,
> When compiling the rockchip endpoint driver with -W=1, gcc output the
> following warnings:
>
> drivers/pci/controller/pcie-rockchip-ep.c:59: warning: Function parameter or struct member 'perst_irq' not described in 'rockchip_pcie_ep'
> drivers/pci/controller/pcie-rockchip-ep.c:59: warning: Function parameter or struct member 'perst_asserted' not described in 'rockchip_pcie_ep'
> drivers/pci/controller/pcie-rockchip-ep.c:59: warning: Function parameter or struct member 'link_up' not described in 'rockchip_pcie_ep'
> drivers/pci/controller/pcie-rockchip-ep.c:59: warning: Function parameter or struct member 'link_training' not described in 'rockchip_pcie_ep'
>
> Avoid these warnings by adding the missing field descriptions in
> struct rockchip_pcie_ep kdoc comment.
Applied to controller/rockchip, thank you!
[01/01] PCI: rockchip: Add missing fields descriptions for struct rockchip_pcie_ep
https://git.kernel.org/pci/pci/c/220bd83f9da1
Krzysztof
prev parent reply other threads:[~2024-12-22 21:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 13:34 [PATCH v2] PCI: rockchip: Add missing fields descriptions for struct rockchip_pcie_ep Damien Le Moal
2024-12-17 4:49 ` Manivannan Sadhasivam
2024-12-22 21:12 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241222211250.GD3111282@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=kishon@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox