From: Bjorn Helgaas <helgaas@kernel.org>
To: Hans Zhang <18255117159@163.com>
Cc: manivannan.sadhasivam@linaro.org, kw@linux.com,
kishon@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
rockswang7@gmail.com, kernel test robot <lkp@intel.com>,
Niklas Cassel <cassel@kernel.org>
Subject: Re: [v5] misc: pci_endpoint_test: Fix overflow of bar_size
Date: Fri, 3 Jan 2025 16:12:22 -0600 [thread overview]
Message-ID: <20250103221222.GA10177@bhelgaas> (raw)
In-Reply-To: <20250103220200.GA9636@bhelgaas>
On Fri, Jan 03, 2025 at 04:02:00PM -0600, Bjorn Helgaas wrote:
> On Wed, Jan 01, 2025 at 11:15:09PM +0800, Hans Zhang wrote:
> > With 8GB BAR2, running pcitest -b 2 fails with "TEST FAILED".
> >
> > The return value of the `pci_resource_len` interface is not an integer.
> > Using `pcitest` with an 8GB BAR2, the bar_size of integer type will
> > overflow.
> > Change the data type of bar_size from integer to resource_size_t, to fix
> > the above issue.
>
> Add blank lines between paragraphs.
>
> Looks good to me.
Apart from the kernel test robot error [1], of course. Obviously that
needs to be resolved.
[1] https://lore.kernel.org/r/202501021000.7Cwcopot-lkp@intel.com
next prev parent reply other threads:[~2025-01-03 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-01 15:15 [v5] misc: pci_endpoint_test: Fix overflow of bar_size Hans Zhang
2025-01-02 3:25 ` kernel test robot
2025-01-03 22:02 ` Bjorn Helgaas
2025-01-03 22:12 ` Bjorn Helgaas [this message]
2025-01-04 14:27 ` Hans Zhang
2025-01-04 14:25 ` Hans Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250103221222.GA10177@bhelgaas \
--to=helgaas@kernel.org \
--cc=18255117159@163.com \
--cc=arnd@arndb.de \
--cc=cassel@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=rockswang7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox