From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1257781728 for ; Mon, 6 Jan 2025 16:24:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736180647; cv=none; b=KIu3Inhz96lqDCS1w+KEVKBKfE96MdBzI+DrjoJlGpIf3aqOiA6ATZLJ0gw81lEywPlF7bzbodCcYIRsLT4nFDqBQYc4Vo4XG9lL7kvGd9uOnfH2y5sLRT22/lIJGe5RDdInbAw3tX81dePswQTiIG4dBIdSmDkuQLfLbHrMgE4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736180647; c=relaxed/simple; bh=ELpWKSlR1Z2yTr8KWlNskjTjjdW9g2IMY35PT7jUlBQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Yjo+kITDPREKwr7l3VyzECQVd6D/oELTZo9/MYcV4MoLFkUN4Sor9wSLBqo5eq3IUbnjfz0Cf2AxneR38VwiC8dUl0coFE9qYt+FQYqL4ldoIYNmZRoPjsSWhRsPHzR7dC02DtfXrZ9Ax+R/CTtSmPNXplyy12en5dRcoBdqjR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=EIbu+giF; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EIbu+giF" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2166f1e589cso254883835ad.3 for ; Mon, 06 Jan 2025 08:24:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736180645; x=1736785445; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=1kJILhgpSDQv2eNsTh8ePWX95k+BIGrrFxfbsyCNVHQ=; b=EIbu+giFNPd6yI+nJE/4q5Qibu7o7fYZarzoapZjwbna/U526ceW/37RaJgUBm/wgT Y9cKSylGYqnHvOY/vFL/Av3I8KjkxFh7ExCvhkhaA3RbwKUIZyGZCmhtEP0PEOU4xed0 2rMTdIQaBsvJMVnWjmnmYAp7N5V3bK9priH6d2OtUSi56Zx3PWlO874+vImi5Nf32+Dz NMk94ZbjSb6NMwv8Fgvx9slGbUxshp6rlYxMvPYIRVHzW3fdQ+iIuvjMTdaYFsHElBQq uHsQAAWyQM2hOF7au5Lcww63POt2VWhnUU0dAimV12NsJYF/sip2WCVqVJt9uXqAdlAL dIFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736180645; x=1736785445; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1kJILhgpSDQv2eNsTh8ePWX95k+BIGrrFxfbsyCNVHQ=; b=L+knQ9uIXZXPaMu/HZbcEjQj1M2Jpzqq/0Y4p3z/nHgfQ4lMdCZrxpY7SdM7sv2kaG 5SA/0lfU9cU+nFYcjGC2bl3XIi6gjUWXE0n2Y1NN+rqaF8TbHsJVs8f+IqqDKkHvCDlm Z21HjJCb7SLj83F2mvTN5Q8uv7TYEtfaHxja/zXpuRw4OxjOHGg2ln6Ccc1+uWmweskk VYlsu51DRiRbeaXBQD/Xld0kbShHHS78AmkyB3KMt4yByDJMmyFBsFD75snTF9QwC7z3 aD8RJMLFLKfXk/EtFU7Kb9N3hqIQfTTq7GF4yre6xMDCLCNdTw3BkZ+h+76elFy2V+y7 DLgg== X-Forwarded-Encrypted: i=1; AJvYcCVjArEY5F6xeEE42d5Lz4tWbKHyfZjsKyKfKfqR0C4IPkr7kpCvYP09pr/l84gh9z4agm23kxJvhYU=@vger.kernel.org X-Gm-Message-State: AOJu0YzGc+606RMHERPI+Wd7hbvbKcIa3cw5GEu7bBLPdnnQy2s/a1ah sl87S+0KnD/RoUHDuHI3vJyiLd2focJqivAPIQY4ogi5dpMCmeasUTPYm27Msg== X-Gm-Gg: ASbGnctW6sleIQCqUBLVPDAMu+NICYZplpy1Bmn8YRbgXDRSntsaLr2HIkDH6ScKgLU 9E1ljljRFRHJ3qVBTe5PnRQh0ZtKAeKI/Px2CVTeoFCC3rr4+6knpRgyg2EZ9LWxlXXoR8mQpsI Gz2riyqVpS6XrqmOP/MTJteM35MvbPkzq1PVxIyo0HKEuJA4j/Q/A6zZ4sAYax3hc2Bh5gxNMEH UfdiIxXT3UO6OKNchf+MeyB+vDSmkqnMWmhVvQnFs8X8CQGxi6yEZWSORkzVvDZuVg= X-Google-Smtp-Source: AGHT+IFdRHlYP1im5zetO+/SjNKJaY5KNYN5HfbqNmxIWZ26dMrClumWmmikkawZQrxTttP5oKteOA== X-Received: by 2002:a05:6a00:1706:b0:726:f7c9:7b36 with SMTP id d2e1a72fcca58-72abdd7bacdmr98645349b3a.8.1736180645400; Mon, 06 Jan 2025 08:24:05 -0800 (PST) Received: from thinkpad ([120.60.61.126]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8dba83sm31660071b3a.116.2025.01.06.08.24.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 08:24:04 -0800 (PST) Date: Mon, 6 Jan 2025 21:53:52 +0530 From: Manivannan Sadhasivam To: Jianjun Wang Cc: Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Ryder Lee , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Xavier Chang Subject: Re: [PATCH 5/5] PCI: mediatek-gen3: Keep PCIe power and clocks if suspend-to-idle Message-ID: <20250106162352.neo5pkunbdakizar@thinkpad> References: <20250103060035.30688-1-jianjun.wang@mediatek.com> <20250103060035.30688-6-jianjun.wang@mediatek.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250103060035.30688-6-jianjun.wang@mediatek.com> On Fri, Jan 03, 2025 at 02:00:15PM +0800, Jianjun Wang wrote: > If the target system sleep state is suspend-to-idle, the bridge is > supposed to stay in D0, and the framework will not help to restore its > configuration space, so keep its power and clocks during suspend. > > It's recommended to enable L1ss support, so the link can be changed to > L1.2 state during suspend. > > Signed-off-by: Jianjun Wang > --- > drivers/pci/controller/pcie-mediatek-gen3.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c > index 48f83c2d91f7..11da68910502 100644 > --- a/drivers/pci/controller/pcie-mediatek-gen3.c > +++ b/drivers/pci/controller/pcie-mediatek-gen3.c > @@ -1291,6 +1291,19 @@ static int mtk_pcie_suspend_noirq(struct device *dev) > int err; > u32 val; > > + /* > + * If the target system sleep state is suspend-to-idle, the bridge is supposed to stay in > + * D0, and the framework will not help to restore its configuration space, so keep it's > + * power and clocks during suspend. > + * > + * It's recommended to enable L1ss support, so the link can be changed to L1.2 state during > + * suspend. > + */ > + if (pm_suspend_default_s2idle()) { I think you need: if (pm_suspend_target_state == PM_SUSPEND_TO_IDLE) here and below. > + dev_info(dev, "System enter s2idle state, keep PCIe power and clocks\n"); There is absolutely no reason to print this message every time system suspend happens. Even dev_dbg() seems unnecessary to me. - Mani > + return 0; > + } > + > /* Trigger link to L2 state */ > err = mtk_pcie_turn_off_link(pcie); > if (err) { > @@ -1316,6 +1329,11 @@ static int mtk_pcie_resume_noirq(struct device *dev) > struct mtk_gen3_pcie *pcie = dev_get_drvdata(dev); > int err; > > + if (pm_suspend_default_s2idle()) { > + dev_info(dev, "System enter s2idle state, no need to reinitialization\n"); > + return 0; > + } > + > err = pcie->soc->power_up(pcie); > if (err) > return err; > -- > 2.46.0 > -- மணிவண்ணன் சதாசிவம்