Re: [PATCH v3 4/6] PCI: dwc: Add support for new pci function op

Bjorn Helgaas
2024-11-12T23:32:04Z

On Tue, Nov 12, 2024 at 08:31:36PM +0530, Krishna chaitanya chundru wrote:
> Add the support for stop_link() and start_link() function op.

When you update the series for the build issue, also update the
subject line here so it's more useful by itself, e.g.,

PCI: dwc: Implement .start_link(), .stop_link() hooks

Seems like the .host_start_link() bits might be a separate patch?
They're not mentioned in this commit log and don't look directly
related.

> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
> ---
> drivers/pci/controller/dwc/pcie-designware-host.c | 18 ++++++++++++++++++
> drivers/pci/controller/dwc/pcie-designware.h | 16 ++++++++++++++++
> 2 files changed, 34 insertions(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
> index 3e41865c7290..d7e7f782390a 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> @@ -691,10 +691,28 @@ void __iomem *dw_pcie_own_conf_map_bus(struct pci_bus *bus, unsigned int devfn,
> }
> EXPORT_SYMBOL_GPL(dw_pcie_own_conf_map_bus);
>
> +static int dw_pcie_op_start_link(struct pci_bus *bus)
> +{
> + struct dw_pcie_rp *pp = bus->sysdata;
> + struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
> +
> + return dw_pcie_host_start_link(pci);
> +}
> +
> +static void dw_pcie_op_stop_link(struct pci_bus *bus)
> +{
> + struct dw_pcie_rp *pp = bus->sysdata;
> + struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
> +
> + dw_pcie_host_stop_link(pci);
> +}
> +
> static struct pci_ops dw_pcie_ops = {
> .map_bus = dw_pcie_own_conf_map_bus,
> .read = pci_generic_config_read,
> .write = pci_generic_config_write,
> + .start_link = dw_pcie_op_start_link,
> + .stop_link = dw_pcie_op_stop_link,
> };
>
> static int dw_pcie_iatu_setup(struct dw_pcie_rp *pp)
> diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
> index 347ab74ac35a..b88b4edafcc3 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.h
> +++ b/drivers/pci/controller/dwc/pcie-designware.h
> @@ -433,6 +433,8 @@ struct dw_pcie_ops {
> enum dw_pcie_ltssm (*get_ltssm)(struct dw_pcie *pcie);
> int (*start_link)(struct dw_pcie *pcie);
> void (*stop_link)(struct dw_pcie *pcie);
> + int (*host_start_link)(struct dw_pcie *pcie);
> + void (*host_stop_link)(struct dw_pcie *pcie);
> };
>
> struct dw_pcie {
> @@ -665,6 +667,20 @@ static inline void dw_pcie_stop_link(struct dw_pcie *pci)
> pci->ops->stop_link(pci);
> }
>
> +static inline int dw_pcie_host_start_link(struct dw_pcie *pci)
> +{
> + if (pci->ops && pci->ops->host_start_link)
> + return pci->ops->host_start_link(pci);
> +
> + return 0;
> +}
> +
> +static inline void dw_pcie_host_stop_link(struct dw_pcie *pci)
> +{
> + if (pci->ops && pci->ops->host_stop_link)
> + pci->ops->host_stop_link(pci);
> +}
> +
> static inline enum dw_pcie_ltssm dw_pcie_get_ltssm(struct dw_pcie *pci)
> {
> u32 val;
>
> --
> 2.34.1
>