From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
"Yazen Ghannam" <yazen.ghannam@amd.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Mahesh J Salgaonkar" <mahesh@linux.ibm.com>,
"Oliver O'Halloran" <oohall@gmail.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v9 0/8] PCI: Consolidate TLP Log reading and printing
Date: Tue, 14 Jan 2025 19:08:32 +0200 [thread overview]
Message-ID: <20250114170840.1633-1-ilpo.jarvinen@linux.intel.com> (raw)
This series has the remaining patches of the AER & DPC TLP Log handling
consolidation and now includes a few minor improvements to the earlier
accepted TLP Logging code.
v9:
- Added patch to define header logging register sizes.
v8:
- Added missing parameter to kerneldoc.
- Dropped last patch due to conflict with the pci_printk() cleanup
series (will move the patch into that series).
v7:
- Explain in commit message reasoning why eetlp_prefix_max stores Max
End-End TLP Prefixes value instead of limiting it by the bridge/RP
imposed limits
- Take account TLP Prefix Log Present flag.
- Align PCI_ERR_CAP_* flags in pci_regs.h
- Add EE_PREFIX_STR define to be able to take its sizeof() for output
char[] sizing.
v6:
- Preserve "AER:"/"DPC:" prefix on the printed TLP line
- New patch to add "AER:" also on other lines of the AER error dump
v5:
- Fix build with AER=y and DPC=n
- Match kerneldoc and function parameter name
v4:
- Added patches:
- Remove EXPORT of pcie_read_tlp_log()
- Moved code to pcie/tlp.c and build only with AER enabled
- Match variables in prototype and function
- int -> unsigned int conversion
- eetlp_prefix_max into own patch
- struct pcie_tlp_log param consistently called "log" within tlp.c
- Moved function prototypes into drivers/pci/pci.h
- Describe AER/DPC differences more clearly in one commit message
v3:
- Small rewording in a commit message
v2:
- Don't add EXPORT()s
- Don't include igxbe changes
- Don't use pr_cont() as it's incompatible with pci_err() and according
to Andy Shevchenko should not be used in the first place
Ilpo Järvinen (8):
PCI: Don't expose pcie_read_tlp_log() outside of PCI subsystem
PCI: Move TLP Log handling to own file
PCI: Add defines for TLP Header/Prefix log sizes
PCI: Make pcie_read_tlp_log() signature same
PCI: Use unsigned int i in pcie_read_tlp_log()
PCI: Store # of supported End-End TLP Prefixes
PCI: Add TLP Prefix reading into pcie_read_tlp_log()
PCI: Create helper to print TLP Header and Prefix Log
drivers/pci/ats.c | 2 +-
drivers/pci/pci.c | 28 ---------
drivers/pci/pci.h | 9 +++
drivers/pci/pcie/Makefile | 2 +-
drivers/pci/pcie/aer.c | 15 ++---
drivers/pci/pcie/dpc.c | 22 +++----
drivers/pci/pcie/tlp.c | 115 ++++++++++++++++++++++++++++++++++
drivers/pci/probe.c | 14 +++--
drivers/pci/quirks.c | 6 +-
include/linux/aer.h | 12 +++-
include/linux/pci.h | 2 +-
include/uapi/linux/pci_regs.h | 11 ++--
12 files changed, 172 insertions(+), 66 deletions(-)
create mode 100644 drivers/pci/pcie/tlp.c
base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
--
2.39.5
next reply other threads:[~2025-01-14 17:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 17:08 Ilpo Järvinen [this message]
2025-01-14 17:08 ` [PATCH v9 1/8] PCI: Don't expose pcie_read_tlp_log() outside of PCI subsystem Ilpo Järvinen
2025-01-14 17:08 ` [PATCH v9 2/8] PCI: Move TLP Log handling to own file Ilpo Järvinen
2025-01-14 17:08 ` [PATCH v9 3/8] PCI: Add defines for TLP Header/Prefix log sizes Ilpo Järvinen
2025-01-14 18:36 ` Jonathan Cameron
2025-01-14 17:08 ` [PATCH v9 4/8] PCI: Make pcie_read_tlp_log() signature same Ilpo Järvinen
2025-01-14 17:08 ` [PATCH v9 5/8] PCI: Use unsigned int i in pcie_read_tlp_log() Ilpo Järvinen
2025-01-14 17:08 ` [PATCH v9 6/8] PCI: Store # of supported End-End TLP Prefixes Ilpo Järvinen
2025-01-14 17:08 ` [PATCH v9 7/8] PCI: Add TLP Prefix reading into pcie_read_tlp_log() Ilpo Järvinen
2025-01-14 17:08 ` [PATCH v9 8/8] PCI: Create helper to print TLP Header and Prefix Log Ilpo Järvinen
2025-01-14 23:51 ` [PATCH v9 0/8] PCI: Consolidate TLP Log reading and printing Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114170840.1633-1-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas@wunner.de \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox