Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Purva Yeshi <purvayeshi550@gmail.com>
To: bhelgaas@google.com
Cc: skhan@linuxfoundation.org, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Purva Yeshi <purvayeshi550@gmail.com>
Subject: [PATCH] drivers: pci: Fix flexible array usage
Date: Mon, 10 Feb 2025 18:57:40 +0530	[thread overview]
Message-ID: <20250210132740.20068-1-purvayeshi550@gmail.com> (raw)

Fix warning detected by smatch tool:
Array of flexible structure occurs in 'pci_saved_state' struct

The warning occurs because struct pci_saved_state contains struct
pci_cap_saved_data cap[], where cap[] has a flexible array member (data[]).
Arrays of structures with flexible members are not allowed, leading to this
warning.

Replaced cap[] with a pointer (*cap), allowing dynamic memory allocation
instead of embedding an invalid array of flexible structures.

Signed-off-by: Purva Yeshi <purvayeshi550@gmail.com>
---
 drivers/pci/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 869d204a7..648a080ef 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -1929,7 +1929,7 @@ EXPORT_SYMBOL(pci_restore_state);
 
 struct pci_saved_state {
 	u32 config_space[16];
-	struct pci_cap_saved_data cap[];
+	struct pci_cap_saved_data *cap;
 };
 
 /**
-- 
2.34.1


             reply	other threads:[~2025-02-10 13:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10 13:27 Purva Yeshi [this message]
2025-02-10 22:47 ` [PATCH] drivers: pci: Fix flexible array usage Bjorn Helgaas
2025-02-10 23:03 ` Keith Busch
2025-02-11 21:02   ` Bjorn Helgaas
2025-02-11 21:18     ` Keith Busch
2025-02-13 10:48       ` Purva Yeshi
2025-02-13 14:41       ` Ilpo Järvinen
2025-02-13 10:42     ` Purva Yeshi
2025-02-13 10:37   ` Purva Yeshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250210132740.20068-1-purvayeshi550@gmail.com \
    --to=purvayeshi550@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox