Re: [RESEND PATCH] PCI: cpci: remove unused fields

Christophe JAILLET
2025-02-15T08:57:54Z

Le 15/02/2025 à 03:10, Guilherme Giacomo Simoes a écrit :
> Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
>> If neither get_power nor set_power where defined in any driver, then
>> cpci_get_power_status() was always returning 1.
>>
>> IIUC, now it may return 1 or 0 depending of if enable_slot() or
>> disable_slot() have been called.
> You is right... ever return 1, but, this is a expected behavior?
> Don't seems for me, that ever return 1 is the right way.
>
>> I don't know the impact of this change and I dont know if it is correct,
>> but I think you should explain why this change of behavior is fine.
> I submitt this patch only with intention that save resources removing the
> get_power and set_power pointers and yours calls.

So, if unsure if the change of behavior you introduce is correct, you
should only do what you wanted to do.

If you still want to propose the other change, you should do the 2
things in 2 different steps.

CJ

>
> Thoughts ??
>
> Thanks,
> Guilherme
>
>