From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Tsai Sung-Fu <danielsftsai@google.com>
Cc: "Jingoo Han" <jingoohan1@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"Brian Norris" <briannorris@google.com>,
"Andrew Chant" <achant@google.com>,
"Sajid Dalvi" <sdalvi@google.com>
Subject: Re: [PATCH] PCI: dwc: Separate MSI out to different controller
Date: Fri, 14 Feb 2025 12:45:52 +0530 [thread overview]
Message-ID: <20250214071552.l4fufap6q5latcit@thinkpad> (raw)
In-Reply-To: <CAK7fddDkQX1aj5ZyTjh1_Pk+XME3AY=m5ouEFRgmLuJjBJytbA@mail.gmail.com>
On Tue, Feb 11, 2025 at 04:23:53PM +0800, Tsai Sung-Fu wrote:
> >Because you cannot set affinity for chained MSIs as these MSIs are muxed to
> >another parent interrupt. Since the IRQ affinity is all about changing which CPU
> >gets the IRQ, affinity setting is only possible for the MSI parent.
>
> So if we can find the MSI parent by making use of chained
> relationships (32 MSI vectors muxed to 1 parent),
> is it possible that we can add that implementation back ?
> We have another patch that would like to add the
> dw_pci_msi_set_affinity feature.
> Would it be a possible try from your perspective ?
>
This question was brought up plenty of times and the concern from the irqchip
maintainer Marc was that if you change the affinity of the parent when the child
MSI affinity changes, it tends to break the userspace ABI of the parent.
See below links:
https://lore.kernel.org/all/87mtg0i8m8.wl-maz@kernel.org/
https://lore.kernel.org/all/874k0bf7f7.wl-maz@kernel.org/
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2025-02-14 7:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 8:32 [PATCH] PCI: dwc: Separate MSI out to different controller Daniel Tsai
2025-01-15 21:23 ` Bjorn Helgaas
2025-01-27 10:07 ` Manivannan Sadhasivam
2025-02-11 7:16 ` Tsai Sung-Fu
2025-02-11 7:56 ` Manivannan Sadhasivam
2025-02-11 8:22 ` Tsai Sung-Fu
2025-02-11 8:23 ` Tsai Sung-Fu
2025-02-14 7:15 ` Manivannan Sadhasivam [this message]
2025-02-14 19:54 ` Brian Norris
2025-02-19 17:51 ` Manivannan Sadhasivam
2025-02-19 18:02 ` Marc Zyngier
2025-02-19 18:09 ` Manivannan Sadhasivam
2025-03-03 7:08 ` Tsai Sung-Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250214071552.l4fufap6q5latcit@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=achant@google.com \
--cc=bhelgaas@google.com \
--cc=briannorris@google.com \
--cc=danielsftsai@google.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
--cc=sdalvi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox