From: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
To: christophe.jaillet@wanadoo.fr
Cc: bhelgaas@google.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, scott@spiteful.org,
trintaeoitogc@gmail.com
Subject: Re: [RESEND PATCH] PCI: cpci: remove unused fields
Date: Fri, 14 Feb 2025 23:10:54 -0300 [thread overview]
Message-ID: <20250215021054.222787-1-trintaeoitogc@gmail.com> (raw)
In-Reply-To: <a1af3a07-1e76-488b-82f7-87b3a4907f26@wanadoo.fr>
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> If neither get_power nor set_power where defined in any driver, then
> cpci_get_power_status() was always returning 1.
>
> IIUC, now it may return 1 or 0 depending of if enable_slot() or
> disable_slot() have been called.
You is right... ever return 1, but, this is a expected behavior?
Don't seems for me, that ever return 1 is the right way.
> I don't know the impact of this change and I dont know if it is correct,
> but I think you should explain why this change of behavior is fine.
I submitt this patch only with intention that save resources removing the
get_power and set_power pointers and yours calls.
Thoughts ??
Thanks,
Guilherme
next prev parent reply other threads:[~2025-02-15 2:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 17:39 [RESEND PATCH] PCI: cpci: remove unused fields Guilherme Giacomo Simoes
2025-02-13 20:44 ` Christophe JAILLET
2025-02-15 2:10 ` Guilherme Giacomo Simoes [this message]
2025-02-15 8:56 ` Christophe JAILLET
2025-02-15 14:05 ` Guilherme Giacomo Simoes
2025-02-13 21:26 ` Bjorn Helgaas
2025-02-15 2:06 ` Guilherme Giacomo Simoes
-- strict thread matches above, loose matches on Subject: below --
2025-01-30 14:01 Guilherme Giacomo Simoes
2025-01-16 15:55 Guilherme Giacomo Simoes
2025-01-02 15:26 Guilherme Giacomo Simoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250215021054.222787-1-trintaeoitogc@gmail.com \
--to=trintaeoitogc@gmail.com \
--cc=bhelgaas@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=scott@spiteful.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox