From: Alex Deucher <alexander.deucher@amd.com>
To: <bhelgaas@google.com>, <linux-pci@vger.kernel.org>,
<amd-gfx@lists.freedesktop.org>
Cc: Mario.Limonciello@amd.com,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Nirmoy Das" <nirmoy.aiemd@gmail.com>
Subject: [PATCH] PCI: fix Sapphire PCI rebar quirk
Date: Mon, 17 Feb 2025 10:10:53 -0500 [thread overview]
Message-ID: <20250217151053.420882-1-alexander.deucher@amd.com> (raw)
There was a quirk added to add a workaround for a Sapphire
RX 5600 XT Pulse. However, the quirk only checks the vendor
ids and not the subsystem ids. The quirk really should
have checked the subsystem vendor and device ids as now
this quirk gets applied to all RX 5600 and it seems to
cause problems on some Dell laptops. Add a subsystem vendor
id check to limit the quirk to Sapphire boards.
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1707
Fixes: 907830b0fc9e ("PCI: Add a REBAR size quirk for Sapphire RX 5600 XT Pulse")
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Nirmoy Das <nirmoy.aiemd@gmail.com>
---
drivers/pci/pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 225a6cd2e9ca3..dec917636974e 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -3766,6 +3766,7 @@ u32 pci_rebar_get_possible_sizes(struct pci_dev *pdev, int bar)
/* Sapphire RX 5600 XT Pulse has an invalid cap dword for BAR 0 */
if (pdev->vendor == PCI_VENDOR_ID_ATI && pdev->device == 0x731f &&
+ pdev->subsystem_vendor == 0x1da2 &&
bar == 0 && cap == 0x700)
return 0x3f00;
--
2.48.1
next reply other threads:[~2025-02-17 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 15:10 Alex Deucher [this message]
2025-02-17 15:30 ` [PATCH] PCI: fix Sapphire PCI rebar quirk Christian König
2025-02-17 15:45 ` Alex Deucher
2025-02-17 16:00 ` Alex Deucher
2025-02-17 16:04 ` Mario Limonciello
2025-02-18 8:03 ` Christian König
2025-02-18 9:58 ` Lazar, Lijo
2025-02-18 11:31 ` Christian König
2025-02-20 14:08 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217151053.420882-1-alexander.deucher@amd.com \
--to=alexander.deucher@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=linux-pci@vger.kernel.org \
--cc=nirmoy.aiemd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox