From: Kever Yang <kever.yang@rock-chips.com>
To: heiko@sntech.de
Cc: linux-rockchip@lists.infradead.org,
"Kever Yang" <kever.yang@rock-chips.com>,
"Simon Xue" <xxm@rock-chips.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, "Krzysztof Wilczyński" <kw@linux.com>,
linux-kernel@vger.kernel.org,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
devicetree@vger.kernel.org,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v6 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support
Date: Fri, 21 Feb 2025 18:43:56 +0800 [thread overview]
Message-ID: <20250221104357.1514128-2-kever.yang@rock-chips.com> (raw)
In-Reply-To: <20250221104357.1514128-1-kever.yang@rock-chips.com>
rk3576 is using dwc controller, with msi interrupt directly to gic instead
of to gic its, so
- no its support is required and the 'msi-map' is not need anymore,
- a new 'msi' interrupt is needed.
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---
Changes in v6:
- Fix make dt_binding_check and make CHECK_DTBS=y
Changes in v5:
- Add constraints per device for interrupt-names due to the interrupt is
different from rk3588.
Changes in v4:
- Fix wrong indentation in dt_binding_check report by Rob
Changes in v3:
- Fix dtb check broken on rk3588
- Update commit message
Changes in v2:
- remove required 'msi-map'
- add interrupt name 'msi'
.../bindings/pci/rockchip-dw-pcie-common.yaml | 59 +++++++++++++++----
.../bindings/pci/rockchip-dw-pcie.yaml | 4 +-
2 files changed, 50 insertions(+), 13 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml
index cc9adfc7611c..069eb267c0bb 100644
--- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml
+++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml
@@ -64,6 +64,10 @@ properties:
interrupts - aer_rc_err, aer_rc_err_msi, rx_cpl_timeout,
tx_cpl_timeout, cor_err_sent, nf_err_sent, f_err_sent, cor_err_rx,
nf_err_rx, f_err_rx, radm_qoverflow
+ - description:
+ Combinded MSI line interrupt, which is to support MSI interrupts
+ output to GIC controller via GIC SPI interrupt instead of GIC its
+ interrupt.
- description:
eDMA write channel 0 interrupt
- description:
@@ -75,16 +79,6 @@ properties:
interrupt-names:
minItems: 5
- items:
- - const: sys
- - const: pmc
- - const: msg
- - const: legacy
- - const: err
- - const: dma0
- - const: dma1
- - const: dma2
- - const: dma3
num-lanes: true
@@ -123,4 +117,49 @@ required:
additionalProperties: true
+anyOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - rockchip,rk3568-pcie
+ - rockchip,rk3588-pcie
+ - rockchip,rk3588-pcie-ep
+ then:
+ properties:
+ interrupt-names:
+ minItems: 5
+ type: array
+ items:
+ - const: sys
+ - const: pmc
+ - const: msg
+ - const: legacy
+ - const: err
+ - const: dma0
+ - const: dma1
+ - const: dma2
+ - const: dma3
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - rockchip,rk3576-pcie
+ then:
+ properties:
+ interrupt-names:
+ type: array
+ items:
+ - const: sys
+ - const: pmc
+ - const: msg
+ - const: legacy
+ - const: err
+ - const: msi
+ minItems: 6
+ maxItems: 6
+
...
diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
index 550d8a684af3..9a464731fa4a 100644
--- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
@@ -26,6 +26,7 @@ properties:
- const: rockchip,rk3568-pcie
- items:
- enum:
+ - rockchip,rk3576-pcie
- rockchip,rk3588-pcie
- const: rockchip,rk3568-pcie
@@ -71,9 +72,6 @@ properties:
vpcie3v3-supply: true
-required:
- - msi-map
-
unevaluatedProperties: false
examples:
--
2.25.1
next prev parent reply other threads:[~2025-02-21 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 10:43 [RFC PATCH v6 0/2] Add rk3576 pcie dts nodes Kever Yang
2025-02-21 10:43 ` Kever Yang [this message]
2025-02-21 12:29 ` [RFC PATCH v6 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support Rob Herring (Arm)
2025-02-21 18:09 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250221104357.1514128-2-kever.yang@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox