Re: [PATCH 1/2] PCI: dwc: ep: Remove superfluous function dw_pcie_ep_find_ext_capability()

[Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>]

On Fri, Feb 21, 2025 at 09:26:47PM +0100, Niklas Cassel wrote:
> Remove the superfluous function dw_pcie_ep_find_ext_capability(), as it is
> virtually identical to dw_pcie_find_ext_capability().
> 
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

- Mani

> ---
>  .../pci/controller/dwc/pcie-designware-ep.c   | 24 +++----------------
>  1 file changed, 3 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
> index f9d7f3f989ad..20f2436c7091 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -102,24 +102,6 @@ static u8 dw_pcie_ep_find_capability(struct dw_pcie_ep *ep, u8 func_no, u8 cap)
>  	return __dw_pcie_ep_find_next_cap(ep, func_no, next_cap_ptr, cap);
>  }
>  
> -static unsigned int dw_pcie_ep_find_ext_capability(struct dw_pcie *pci, int cap)
> -{
> -	u32 header;
> -	int pos = PCI_CFG_SPACE_SIZE;
> -
> -	while (pos) {
> -		header = dw_pcie_readl_dbi(pci, pos);
> -		if (PCI_EXT_CAP_ID(header) == cap)
> -			return pos;
> -
> -		pos = PCI_EXT_CAP_NEXT(header);
> -		if (!pos)
> -			break;
> -	}
> -
> -	return 0;
> -}
> -
>  static int dw_pcie_ep_write_header(struct pci_epc *epc, u8 func_no, u8 vfunc_no,
>  				   struct pci_epf_header *hdr)
>  {
> @@ -230,7 +212,7 @@ static unsigned int dw_pcie_ep_get_rebar_offset(struct dw_pcie *pci,
>  	unsigned int offset, nbars;
>  	int i;
>  
> -	offset = dw_pcie_ep_find_ext_capability(pci, PCI_EXT_CAP_ID_REBAR);
> +	offset = dw_pcie_find_ext_capability(pci, PCI_EXT_CAP_ID_REBAR);
>  	if (!offset)
>  		return offset;
>  
> @@ -847,7 +829,7 @@ static void dw_pcie_ep_init_non_sticky_registers(struct dw_pcie *pci)
>  	enum pci_barno bar;
>  	u32 reg, i, val;
>  
> -	offset = dw_pcie_ep_find_ext_capability(pci, PCI_EXT_CAP_ID_REBAR);
> +	offset = dw_pcie_find_ext_capability(pci, PCI_EXT_CAP_ID_REBAR);
>  
>  	dw_pcie_dbi_ro_wr_en(pci);
>  
> @@ -970,7 +952,7 @@ int dw_pcie_ep_init_registers(struct dw_pcie_ep *ep)
>  	if (ep->ops->init)
>  		ep->ops->init(ep);
>  
> -	ptm_cap_base = dw_pcie_ep_find_ext_capability(pci, PCI_EXT_CAP_ID_PTM);
> +	ptm_cap_base = dw_pcie_find_ext_capability(pci, PCI_EXT_CAP_ID_PTM);
>  
>  	/*
>  	 * PTM responder capability can be disabled only after disabling
> -- 
> 2.48.1
> 

-- 
மணிவண்ணன் சதாசிவம்