From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Mrinmay Sarkar" <quic_msarkar@quicinc.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 6/8] PCI: dwc: pcie-qcom-ep: enable EP support for SAR2130P
Date: Sun, 23 Feb 2025 14:18:33 +0530 [thread overview]
Message-ID: <20250223084833.xdckixxfezlwovgw@thinkpad> (raw)
In-Reply-To: <48B09581-F4AA-4196-8445-1E02041915AF@linaro.org>
On Sat, Feb 22, 2025 at 08:06:02PM +0200, Dmitry Baryshkov wrote:
> On 22 February 2025 18:50:38 EET, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
> >On Fri, Feb 21, 2025 at 05:52:04PM +0200, Dmitry Baryshkov wrote:
> >> Enable PCIe endpoint support for the Qualcomm SAR2130P platform. It is
> >> impossible to use fallback compatible to any other platform since
> >> SAR2130P uses slightly different set of clocks.
> >>
> >
> >Still, why do you want the compatible to be added to the driver? It shall be
> >defined in the binding with the respective clock difference. Driver should just
> >work with the fallback compatible.
>
> Well, per my understanding (or according to my feeling) different set of clocks means that they are not completely compatible. An Ack from DT maintainers supports this.
>
Hmm. Thinking more, I tend to agree. Let's be as it is.
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2025-02-23 8:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 15:51 [PATCH v3 0/8] PCI: qcom-ep: add support for using the EP on SAR2130P and SM8450 Dmitry Baryshkov
2025-02-21 15:51 ` [PATCH v3 1/8] dt-bindings: PCI: qcom-ep: describe optional dma-coherent property Dmitry Baryshkov
2025-02-22 10:31 ` Krzysztof Kozlowski
2025-02-22 16:45 ` Manivannan Sadhasivam
2025-02-21 15:52 ` [PATCH v3 2/8] dt-bindings: PCI: qcom-ep: describe optional IOMMU Dmitry Baryshkov
2025-02-22 10:32 ` Krzysztof Kozlowski
2025-02-22 16:45 ` Manivannan Sadhasivam
2025-02-21 15:52 ` [PATCH v3 3/8] dt-bindings: PCI: qcom-ep: enable DMA for SM8450 Dmitry Baryshkov
2025-02-22 10:32 ` Krzysztof Kozlowski
2025-02-21 15:52 ` [PATCH v3 4/8] dt-bindings: PCI: qcom-ep: consolidate DMA vs non-DMA usecases Dmitry Baryshkov
2025-02-22 10:40 ` Krzysztof Kozlowski
2025-02-22 16:47 ` Manivannan Sadhasivam
2025-02-21 15:52 ` [PATCH v3 5/8] dt-bindings: PCI: qcom-ep: add SAR2130P compatible Dmitry Baryshkov
2025-02-22 10:41 ` Krzysztof Kozlowski
2025-02-21 15:52 ` [PATCH v3 6/8] PCI: dwc: pcie-qcom-ep: enable EP support for SAR2130P Dmitry Baryshkov
2025-02-22 16:50 ` Manivannan Sadhasivam
2025-02-22 18:06 ` Dmitry Baryshkov
2025-02-23 8:48 ` Manivannan Sadhasivam [this message]
2025-02-21 15:52 ` [PATCH v3 7/8] arm64: dts: qcom: sar2130p: add PCIe EP device nodes Dmitry Baryshkov
2025-02-21 18:59 ` Konrad Dybcio
2025-02-22 16:51 ` Manivannan Sadhasivam
2025-02-21 15:52 ` [PATCH v3 8/8] arm64: dts: qcom: sm8450: " Dmitry Baryshkov
2025-02-22 16:53 ` Manivannan Sadhasivam
2025-02-22 14:36 ` [PATCH v3 0/8] PCI: qcom-ep: add support for using the EP on SAR2130P and SM8450 Krzysztof Wilczyński
2025-02-24 18:36 ` Krzysztof Wilczyński
2025-02-25 3:19 ` Dmitry Baryshkov
2025-03-14 20:00 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250223084833.xdckixxfezlwovgw@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kw@linux.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=quic_msarkar@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox