public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: jingoohan1@gmail.com, lpieralisi@kernel.org, robh@kernel.org,
	bhelgaas@google.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, shradha.t@samsung.com,
	cassel@kernel.org
Subject: Re: [PATCH 2/2] PCI: dwc-debugfs: Return -EOPNOTSUPP if an event counter is not supported
Date: Wed, 26 Feb 2025 15:56:50 +0900	[thread overview]
Message-ID: <20250226065650.GC951736@rocinante> (raw)
In-Reply-To: <20250225171239.19574-3-manivannan.sadhasivam@linaro.org>

Hello,

> If the platform doesn't support an event counter, enabling it using the
> 'counter_enable' debugfs attribute currently will succeed. But reading the
> debugfs attribute back will return 'Counter Disabled'.
> 
> This could cause confusion to the users. So while enabling an event
> counter in counter_enable_write(), always read back the status to check if
> the counter is enabled or not. If not, return -EOPNOTSUPP to let the users
> know that the event counter is not supported.

Thank you for following up on this.  Appreciated.  With that...

Reviewed-by: Krzysztof Wilczyński <kwilczynski@kernel.org>

Thank you!

	Krzysztof

  reply	other threads:[~2025-02-26  6:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25 17:12 [PATCH 0/2] PCI: dwc-debugfs: Couple of fixes Manivannan Sadhasivam
2025-02-25 17:12 ` [PATCH 1/2] PCI: dwc-debugfs: Perform deinit only when the debugfs is initialized Manivannan Sadhasivam
2025-02-26  6:53   ` Krzysztof Wilczyński
2025-02-25 17:12 ` [PATCH 2/2] PCI: dwc-debugfs: Return -EOPNOTSUPP if an event counter is not supported Manivannan Sadhasivam
2025-02-26  6:56   ` Krzysztof Wilczyński [this message]
2025-02-26  1:55 ` [PATCH 0/2] PCI: dwc-debugfs: Couple of fixes Hans Zhang
2025-02-26  7:43   ` Krzysztof Wilczyński
2025-02-26  7:45     ` Hans Zhang
2025-02-26  7:17 ` Krzysztof Wilczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250226065650.GC951736@rocinante \
    --to=kw@linux.com \
    --cc=bhelgaas@google.com \
    --cc=cassel@kernel.org \
    --cc=jingoohan1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=robh@kernel.org \
    --cc=shradha.t@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox