Linux PCI subsystem development
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: Hans Zhang <18255117159@163.com>
Cc: kernel test robot <lkp@intel.com>,
	oe-kbuild-all@lists.linux.dev, linux-pci@vger.kernel.org,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [pci:controller/dwc 6/8] drivers/pci/controller/dwc/pcie-designware-debugfs.c:561:undefined reference to `dw_ltssm_sts_string'
Date: Thu, 27 Feb 2025 19:43:53 +0900	[thread overview]
Message-ID: <20250227104353.GA961034@rocinante> (raw)
In-Reply-To: <ef04f32a-593f-437d-8465-1634c12567ae@163.com>

Hello,

> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/dwc
> > head:   b9d6619b0c3ef6ac25764ff29b08e8c1953ea83f
> > commit: d4dc748566221bfdd0345c282ec82d3eee457f39 [6/8] PCI: dwc: Add debugfs property to provide LTSSM status of the PCIe link
> > config: sparc64-randconfig-001-20250227 (https://download.01.org/0day-ci/archive/20250227/202502270336.4xpaTVPE-lkp@intel.com/config)
[...]
> sparc64-randconfig-001-20250227:
> 
> #
> # DesignWare-based PCIe controllers
> #
> CONFIG_PCIE_DW=y
> CONFIG_PCIE_DW_DEBUGFS=y
> CONFIG_PCIE_DW_EP=y
> 
> 
> Since this config is not configured with CONFIG_PCIE_DW_HOST, and the
> dw_ltssm_sts_string function is in the pci-designware-host.c, the following
> compilation error occurs.

No worries.  Thank you for having a look!

> Can you help move the dw_ltssm_sts_string function to pci-designware.c or
> pci-designware-debugfs.c?

Have a look at the following:

  https://web.git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/dwc&id=02001ce4ff42bd85be3ed8b4a0a2580156f032a0

And let me know if this is OK with you.
 
> Or should I resubmit v6 patch?

No, need.  Thank you anyway, though.

	Krzysztof

  reply	other threads:[~2025-02-27 10:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26 20:09 [pci:controller/dwc 6/8] drivers/pci/controller/dwc/pcie-designware-debugfs.c:561:undefined reference to `dw_ltssm_sts_string' kernel test robot
2025-02-27  1:55 ` Hans Zhang
2025-02-27 10:43   ` Krzysztof Wilczyński [this message]
2025-02-27 11:27     ` Hans Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250227104353.GA961034@rocinante \
    --to=kwilczynski@kernel.org \
    --cc=18255117159@163.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox