From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6AF22040A8 for ; Tue, 4 Mar 2025 13:25:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741094738; cv=none; b=U4P+ZhyYd1+VG33OEjRDSoU+xidtM6aNqdPX8HE1QdQ7CscEkLCxPstMLyOgCC9W+KumVu1H9+SJkkZ0IUiONcavdkVhg7bSA4FtqwNIKOEW1BpJ9Uy2e7pe8bI7XhMC+SYVUCsg/xKDUAELuRZEI69wWAm4x7CayAKwE4kYh4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741094738; c=relaxed/simple; bh=hrg5TRRNBdLUQ2zHXbLHEUeFopncg9X6mHK4DEu8vEw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Aroivey95r4rIBoXQYfkv15X2kiosw64TknIvnjFRwZD4Wg+mYln1KbGOCwEbZSfXNMbk42hDmBtwbfcmSia8KDu3+PoArId7BX35F9N8wOHH0a0W5z6Vu8QfdzVyKioLThSnRI6+QiMOOZ4BEY82ZoDnZlrBm0STGPTtRXmSkc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qjmT5HUk; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qjmT5HUk" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2feaca4e99cso8105682a91.0 for ; Tue, 04 Mar 2025 05:25:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741094735; x=1741699535; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=zRzp39M4FPV3rBLrWF5aPlMpMnqpUTW4xLGh7q0S7c8=; b=qjmT5HUkZatu/IaG1QbzTq5fJIjV/z3LvkdNtNELWOY56VCjtZzP1/a1scr5uZ8UqW IQls4t5lAe2/gScJnTooK4VOpQ0w+K72LquK8sZ59+OZnE4WZ8el5CZvrKNvYYArrPyC FpSV2R8JnOaFQlTrmULiAKoPOwJBa43GOUt62WtxX7gQ5GsfENig9IWA55ESXeQWF6bT 8MYCPa41oZc8dNKsdd36ZOo4BnTvKo+VhuNCjak5Kn0R+bpzr52g7yUlkMrWjFNXzNar CAWB81wrWwjmSVjYRrQ+hYCkLX/XPs+ZGAe5C2xREEJGP6mNlx2k6mZokXwrYsQP8YKW 3VnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741094735; x=1741699535; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zRzp39M4FPV3rBLrWF5aPlMpMnqpUTW4xLGh7q0S7c8=; b=km5qGVsG9GIidy/8sbalHWmjWVPHf8/nM9SksQMaa1IPmW/oGIfiqJeycfOSMFKK5W 46CPjLexKYE+Ld/qXKkdaQIJmJ6/PCwi74/UtNn4WYZMiWKb7Mr7sfO/TWl7Qc+Ai8OA Q1aBsp9RG+GNqcmhPCTrVJpqQs3jU9Dh+bnXmcL49Pw5T9EIY2r9OQaXdrW3q8d4GFNS RTOZltsXdVllB20UifgtqwXGy0A4k042W7qnH7V5S6xP8BF1Pl6Xzm0EGdX6m+Ujlk+L zmeFuP8mlEyFIcxT9tybvcln+idh1V5l+sZJ5MguL07okvVUXmIgUt7vflRaWhdjQ6qF 5/Uw== X-Forwarded-Encrypted: i=1; AJvYcCU/O5CnxJznEll6yPn3GWUWnC92MJCn5p0lTZcekTNCEOKWz60Hk8SkiWysq0GnR2W1rbObE9+zbRg=@vger.kernel.org X-Gm-Message-State: AOJu0YxKNbpXhKIkFPlutRYhK+HyZWA7DX2QY+4Srtsmea6i2crxT4J8 jJSOXKxsW5MPGnF/cADOmZtrvjqolNOteNVKCOQNO0wzKjthrmadkHsTB10KOw== X-Gm-Gg: ASbGncsBkxcOsDOt0AUceEjHlOAEJfUgItr7gUD/WW4ZDVlbv4Havto0IL4f2YDWejU /WZgcwbrEt04B0qjtjoqFVU+LNtIaOcllIjk+qna0suVT3ZANpKxMayKNpExrZHQU397EOLEKcS nN/9mk3b7fdL0bkIoHXwszXm1w77CLjJWkPVsH2YP37rNKzXIH8swux28kAERir8BkdKINvbKWm PCkCvg+DBw3BnQ9SaD2NFPbOu+yYfQr9DZxo7l6eS9B4vvF4cFRmK4+yxXZey1CgKG50d8G+IUl WFxSAjudJ2ZnKV/lQlFCU/lysmyLCHQb0hIlm0Sr4QGRKTCqIS9f51E= X-Google-Smtp-Source: AGHT+IGMgJGJf8roiOEdiQxTQJjbdJo8uZPWuNkxO43X2UqljjgGxIyM2jVruHLjEl9BEsxN4NrLWQ== X-Received: by 2002:a17:90b:4a01:b0:2fe:9fd4:58f4 with SMTP id 98e67ed59e1d1-2febab78d41mr29375712a91.16.1741094734730; Tue, 04 Mar 2025 05:25:34 -0800 (PST) Received: from thinkpad ([120.60.51.199]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fe825a98f2sm13028887a91.7.2025.03.04.05.25.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 05:25:34 -0800 (PST) Date: Tue, 4 Mar 2025 18:55:27 +0530 From: Manivannan Sadhasivam To: Sai Krishna Musham Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, cassel@kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, michal.simek@amd.com, bharat.kumar.gogada@amd.com, thippeswamy.havalige@amd.com Subject: Re: [PATCH v3 1/2] dt-bindings: PCI: xilinx-cpm: Add reset-gpios for PCIe RP PERST# Message-ID: <20250304132527.gu3husgouddth4x6@thinkpad> References: <20250227042454.907182-1-sai.krishna.musham@amd.com> <20250227042454.907182-2-sai.krishna.musham@amd.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250227042454.907182-2-sai.krishna.musham@amd.com> On Thu, Feb 27, 2025 at 09:54:53AM +0530, Sai Krishna Musham wrote: > Introduce `reset-gpios` property to enable GPIO-based control of > the PCIe RP PERST# signal, generating assert and deassert signals. > > Traditionally, the reset was managed in hardware and enabled during > initialization. With this patch set, the reset will be handled by the > driver. Consequently, the `reset-gpios` property must be explicitly > provided to ensure proper functionality. > > Signed-off-by: Sai Krishna Musham Acked-by: Manivannan Sadhasivam - Mani > --- > This patch depends on the following patch series. > https://lore.kernel.org/all/20250217072713.635643-2-thippeswamy.havalige@amd.com/ > > Changes for v3: > - None > > Changes for v2: > - Add define from include/dt-bindings/gpio/gpio.h for PERST# polarity > - Update commit message > --- > .../devicetree/bindings/pci/xilinx-versal-cpm.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml > index b63a759ec2d7..6aaeb76f498b 100644 > --- a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml > +++ b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml > @@ -33,6 +33,9 @@ properties: > - const: cpm_csr > minItems: 2 > > + reset-gpios: > + description: GPIO used as PERST# signal. Please refer to pci.txt. > + > interrupts: > maxItems: 1 > > @@ -63,6 +66,7 @@ properties: > required: > - reg > - reg-names > + - reset-gpios > - "#interrupt-cells" > - interrupts > - interrupt-map > @@ -75,6 +79,7 @@ unevaluatedProperties: false > > examples: > - | > + #include > > versal { > #address-cells = <2>; > @@ -99,6 +104,7 @@ examples: > reg = <0x0 0xfca10000 0x0 0x1000>, > <0x6 0x00000000 0x0 0x10000000>; > reg-names = "cpm_slcr", "cfg"; > + reset-gpios = <&gpio1 38 GPIO_ACTIVE_LOW>; > pcie_intc_0: interrupt-controller { > #address-cells = <0>; > #interrupt-cells = <1>; > @@ -127,6 +133,7 @@ examples: > <0x06 0x00000000 0x00 0x1000000>, > <0x00 0xfce20000 0x00 0x1000000>; > reg-names = "cpm_slcr", "cfg", "cpm_csr"; > + reset-gpios = <&gpio1 38 GPIO_ACTIVE_LOW>; > > pcie_intc_1: interrupt-controller { > #address-cells = <0>; > -- > 2.44.1 > -- மணிவண்ணன் சதாசிவம்