From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F3B528FFD8 for ; Tue, 4 Mar 2025 17:32:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741109538; cv=none; b=WoI8q0hrKSSzbc0irUccCV+rsgKqPia9nm3eF49xC98/NmUG83FcM6/3GDREdKzRijrTigk/9dG6zn+Dz31smAzpFnKAOxQzg4Zl9Oo2WOLEym3AJX2PiuaRY1QAFjgORT1iBXwR2qXf08w0CBGdl7kwzllWSipCMmBnxoOi8Y4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741109538; c=relaxed/simple; bh=GfRaN3GMHCOGJJtYN1aMtMnR1ziLLUOWvjFRsYfDsy8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eunEDlH6GTkL16bNLpHR+ARJM+AkvN4zxpYx+TVVbnY2vAYBs8sE2bHK9I/Z6bGYCmwd4OGAEBw0p8qTTL5ju/62UJNXcxXg65YHBBekGgGK089Ny5WgvhW8KvaqMLgqqu+PirUqisMDwQAdMIxU/BFhtofLJ0EvwDGM4weFTMQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=s//inOZT; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="s//inOZT" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-223cc017ef5so34230955ad.0 for ; Tue, 04 Mar 2025 09:32:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741109536; x=1741714336; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=13UO/bBBmk74lWYurj0NLoL8MAPIZRHSkEPYSBsPdwc=; b=s//inOZTk0BbUWYPsZu5oFPfCzjL9+hYz1y+mlAOupyeWg/nWx8ZcFszFYtaHY8YxJ pr2c6T5MVio9qzD9khzKyNAPs3DWSLLgM7ChMyoNCGE45vAl8PyEJ6pk0NUYZGiVCb14 Bf0FiH635tL7+F6JIZvv49hcozQAokxF3qMvMGiFh3vScZ1gU1Ey6oKi9Yy8FlsiEZtt JRIw+lVE4YwpS3pJCrNIMDzhoV3z43xCtanAY0suFq6pX+76r5UC9q6fqaLB1SuPeSNP S4fqdCRyqXzVxlmVx0eWVUwkOXXuUqQ8DI5nVlQqJlF1Jbsuv9R21GxjSOMX6xrru4zv uRlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741109536; x=1741714336; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=13UO/bBBmk74lWYurj0NLoL8MAPIZRHSkEPYSBsPdwc=; b=fsWp83v4YdsHgdTASEtvklrpS9AR5iNNvXP4RJrJU9Ccn3EwMfrKzZSfcqRcyk4wte fd/QSA5LSBcSl2uJ3gL11fsAvh1egagHVsEktKGTIXpZYlZ2i9Lfx3PdO1rIq3u5DgxX n/Xf2CCbTbgSawzGJqaxvlb9JERVn19JKk23b5o1MGZIpwyZQRnnbdmx/kEB66p2BxBx hWVv5rb/k9pm9dInV5Ek+8zIH37VpRub2nr1Ogu1sQIayjSqA3zswOn0g7cRJs4LAY2j 2VMf1TOFEvr9N9F2Qm0cm1c1C7rxPjA1DeXJdToHug+YjhDvgT3JEfbIB+fyP7JDR0i8 4BKg== X-Gm-Message-State: AOJu0YzO1y18rNAja4jMJOgAfhqxViN5KgVYoczjMlBdJsxY8Vzbp1ys eZqVACJ2xqJIwrbNJCi/z1QzLh6Eco+bOBncPKwKedxofT1aY839zMXYGqZM5A== X-Gm-Gg: ASbGnct7XHMZXrit1G5mtP1Ptj+OkceWEYu3oqAtgkkx8EonpQ+KT4N/3NFi7o9j9xT tsS7ZeON9hFUCtuCf+Tbxh9Deucqma29P5kzqq48hNKczbkHMLOwkPMAmrFNtuVlUxgvvA07UBw gM2glt8mmByLo1MysQy0kabWyoqeeIh9cJCkImQqLvxyzu1lYST0LmdZv29vwe8212/nS7zgM3J HOVEi3I0FMNWNsdo3yD+YTLY25HZovCOpgN2XE5AGCWg1TWZ/Mq5jxoQ6+RI5szgoI6bJLo5rkP cG9XL5y5D5tVEMWe1S+82UhTgY8m1Zet54rw06OYW8fkc33zmA8PJx0= X-Google-Smtp-Source: AGHT+IENsKkUhuv8gc8RI2eXokbdYucKOSdaT4IfgbHgCVm5rtH9K7HDvp2i58wnfep6Wo8pLoIlBg== X-Received: by 2002:a05:6a00:ad0:b0:732:5611:cbb5 with SMTP id d2e1a72fcca58-734ac372044mr29269358b3a.11.1741109536419; Tue, 04 Mar 2025 09:32:16 -0800 (PST) Received: from thinkpad ([120.60.51.199]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-736387b2c1dsm7106697b3a.64.2025.03.04.09.32.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:32:15 -0800 (PST) Date: Tue, 4 Mar 2025 23:02:09 +0530 From: Manivannan Sadhasivam To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v2 4/8] PCI: brcmstb: Fix error path upon call of regulator_bulk_get() Message-ID: <20250304173209.bq2lpijsea7aufpu@thinkpad> References: <20250214173944.47506-1-james.quinlan@broadcom.com> <20250214173944.47506-5-james.quinlan@broadcom.com> <20250304150313.ey4fky35bu6dbtxd@thinkpad> <20250304170735.x25c65azfpd7xmwv@thinkpad> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Mar 04, 2025 at 12:24:56PM -0500, Jim Quinlan wrote: > On Tue, Mar 4, 2025 at 12:07 PM Manivannan Sadhasivam > wrote: > > > > On Tue, Mar 04, 2025 at 11:55:05AM -0500, Jim Quinlan wrote: > > > On Tue, Mar 4, 2025 at 10:03 AM Manivannan Sadhasivam > > > wrote: > > > > > > > > On Fri, Feb 14, 2025 at 12:39:32PM -0500, Jim Quinlan wrote: > > > > > If regulator_bulk_get() returns an error, no regulators are created and we > > > > > need to set their number to zero. If we do not do this and the PCIe > > > > > link-up fails, regulator_bulk_free() will be invoked and effect a panic. > > > > > > > > > > Also print out the error value, as we cannot return an error upwards as > > > > > Linux will WARN on an error from add_bus(). > > > > > > > > > > Fixes: 9e6be018b263 ("PCI: brcmstb: Enable child bus device regulators from DT") > > > > > Signed-off-by: Jim Quinlan > > > > > --- > > > > > drivers/pci/controller/pcie-brcmstb.c | 3 ++- > > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > > > > > index e0b20f58c604..56b49d3cae19 100644 > > > > > --- a/drivers/pci/controller/pcie-brcmstb.c > > > > > +++ b/drivers/pci/controller/pcie-brcmstb.c > > > > > @@ -1416,7 +1416,8 @@ static int brcm_pcie_add_bus(struct pci_bus *bus) > > > > > > > > > > ret = regulator_bulk_get(dev, sr->num_supplies, sr->supplies); > > > > > if (ret) { > > > > > - dev_info(dev, "No regulators for downstream device\n"); > > > > > + dev_info(dev, "Did not get regulators; err=%d\n", ret); > > > > > > > > Why is this dev_info() instead of dev_err()? > > > > > > I will change this. > > > > > > > > > + pcie->sr = NULL; > > > > > > > > Why can't you set 'pcie->sr' after successfull regulator_bulk_get()? > > > > > > Not sure I understand -- it is already set before a successful > > > regulator_bulk_get() call. > > > > Didn't I say 'after'? > > Sorry, I misinterpreted your question. I can change it but it would > just be churn because a new commit is going to refactor this function. > However, > I can set pcie->num_regulators "after" in the new commit. > If a new patch is going to change the beahvior, then I'm fine with it for now. After all, this series is already merged. - Mani -- மணிவண்ணன் சதாசிவம்