From: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
To: cros-qcom-dts-watchers@chromium.org,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
quic_vbadigan@quicinc.com, quic_mrana@quicinc.com,
quic_vpernami@quicinc.com, mmareddy@quicinc.com,
Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Subject: [PATCH v5 5/7] PCI: dwc: qcom: Switch to dwc ELBI resource mapping
Date: Sun, 09 Mar 2025 11:15:27 +0530 [thread overview]
Message-ID: <20250309-ecam_v4-v5-5-8eff4b59790d@oss.qualcomm.com> (raw)
In-Reply-To: <20250309-ecam_v4-v5-0-8eff4b59790d@oss.qualcomm.com>
Instead of using qcom ELBI resources mapping use dwc mapping as this
ELBI is dwc specific.
Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
---
drivers/pci/controller/dwc/pcie-qcom.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index e4d3366ead1f..258b2d615080 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -265,7 +265,6 @@ struct qcom_pcie_cfg {
struct qcom_pcie {
struct dw_pcie *pci;
void __iomem *parf; /* DT parf */
- void __iomem *elbi; /* DT elbi */
void __iomem *mhi;
union qcom_pcie_resources res;
struct phy *phy;
@@ -390,12 +389,13 @@ static void qcom_pcie_configure_dbi_atu_base(struct qcom_pcie *pcie)
static void qcom_pcie_2_1_0_ltssm_enable(struct qcom_pcie *pcie)
{
+ struct dw_pcie *pci = pcie->pci;
u32 val;
/* enable link training */
- val = readl(pcie->elbi + ELBI_SYS_CTRL);
+ val = readl(pci->elbi_base + ELBI_SYS_CTRL);
val |= ELBI_SYS_CTRL_LT_ENABLE;
- writel(val, pcie->elbi + ELBI_SYS_CTRL);
+ writel(val, pci->elbi_base + ELBI_SYS_CTRL);
}
static int qcom_pcie_get_resources_2_1_0(struct qcom_pcie *pcie)
@@ -1631,12 +1631,6 @@ static int qcom_pcie_probe(struct platform_device *pdev)
goto err_pm_runtime_put;
}
- pcie->elbi = devm_platform_ioremap_resource_byname(pdev, "elbi");
- if (IS_ERR(pcie->elbi)) {
- ret = PTR_ERR(pcie->elbi);
- goto err_pm_runtime_put;
- }
-
/* MHI region is optional */
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mhi");
if (res) {
--
2.34.1
next prev parent reply other threads:[~2025-03-09 5:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-09 5:45 [PATCH v5 0/7] PCI: dwc: Add ECAM support with iATU configuration Krishna Chaitanya Chundru
2025-03-09 5:45 ` [PATCH v5 1/7] arm64: dts: qcom: sc7280: Increase config size to 256MB for ECAM feature Krishna Chaitanya Chundru
2025-03-10 9:34 ` Krzysztof Kozlowski
2025-03-11 11:13 ` Konrad Dybcio
2025-03-26 17:56 ` Konrad Dybcio
2025-03-28 11:44 ` Manivannan Sadhasivam
2025-03-28 12:54 ` Krishna Chaitanya Chundru
2025-03-28 15:29 ` Manivannan Sadhasivam
2025-03-28 20:44 ` Konrad Dybcio
2025-03-29 6:25 ` Manivannan Sadhasivam
2025-03-09 5:45 ` [PATCH v5 2/7] dt-bindings: PCI: qcom,pcie-sc7280: Make elbi register as an optional Krishna Chaitanya Chundru
2025-03-10 9:31 ` Krzysztof Kozlowski
2025-03-28 11:48 ` Manivannan Sadhasivam
2025-03-09 5:45 ` [PATCH v5 3/7] arch: arm64: qcom: sc7280: Remove optional elbi register Krishna Chaitanya Chundru
2025-03-10 9:32 ` Krzysztof Kozlowski
2025-03-09 5:45 ` [PATCH v5 4/7] PCI: dwc: Add support for ELBI resource mapping Krishna Chaitanya Chundru
2025-03-28 11:53 ` Manivannan Sadhasivam
2025-03-09 5:45 ` Krishna Chaitanya Chundru [this message]
2025-03-28 11:57 ` [PATCH v5 5/7] PCI: dwc: qcom: Switch to dwc " Manivannan Sadhasivam
2025-03-09 5:45 ` [PATCH v5 6/7] PCI: dwc: Add ECAM support with iATU configuration Krishna Chaitanya Chundru
2025-03-09 5:45 ` [PATCH v5 7/7] PCI: qcom: Add support for ECAM feature Krishna Chaitanya Chundru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250309-ecam_v4-v5-5-8eff4b59790d@oss.qualcomm.com \
--to=krishna.chundru@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=jingoohan1@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mmareddy@quicinc.com \
--cc=quic_mrana@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=quic_vpernami@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox