Linux PCI subsystem development
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: Niklas Cassel <cassel@kernel.org>,
	llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	linux-pci@vger.kernel.org
Subject: Re: [pci:endpoint-test 16/18] drivers/pci/controller/dwc/pcie-dw-rockchip.c:316:3: error: field designator 'intx_capable' does not refer to any field in type 'const struct dw_pcie_ep_ops'
Date: Tue, 11 Mar 2025 03:49:04 +0900	[thread overview]
Message-ID: <20250310184904.GB1179150@rocinante> (raw)
In-Reply-To: <20250310182605.GA1179150@rocinante>

Hello,

> [...]
> > vim +316 drivers/pci/controller/dwc/pcie-dw-rockchip.c
> > 
> >    313	
> >    314	static const struct dw_pcie_ep_ops rockchip_pcie_ep_ops = {
> >    315		.init = rockchip_pcie_ep_init,
> >  > 316		.intx_capable = false,
> >    317		.raise_irq = rockchip_pcie_raise_irq,
> >    318		.get_features = rockchip_pcie_get_features,
> >    319	};
> >    320	
> 
> I moved setting the .intx_capable property to false to the pci_epc_features
> struct definition for RK3568, which is what I believe the intention was.
> 
> Have a look at:
> 
>   https://web.git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=endpoint-test&id=cb349262d9770e6478a7e91bdf438122b8cda44d
> 
> Let me know if this is OK with you.

Niklas, I saw your reply to this failure report.

Based on it, I fixed the patch and dropped any annotations added (since
there was no need to do anything aside from retroing the code to its
orignal form).


That said, I didn't do any edits when applying the patch that I can recall,
so I think something got its knickers in a twist when I was applying the
patches.

However, I did miss that it got applied incorrectly when reviewing the
changes before pushing them.  My bad.

Anyway.  Sorry for the commotion.  I am glad the fix was trivial here.

Thank you!

	Krzysztof

  reply	other threads:[~2025-03-10 18:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-10 18:02 [pci:endpoint-test 16/18] drivers/pci/controller/dwc/pcie-dw-rockchip.c:316:3: error: field designator 'intx_capable' does not refer to any field in type 'const struct dw_pcie_ep_ops' kernel test robot
2025-03-10 18:22 ` Niklas Cassel
2025-03-10 18:26 ` Krzysztof Wilczyński
2025-03-10 18:49   ` Krzysztof Wilczyński [this message]
2025-03-11 10:11     ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250310184904.GB1179150@rocinante \
    --to=kwilczynski@kernel.org \
    --cc=cassel@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox