From: Bjorn Helgaas <helgaas@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] PCI: Move pci_rescan_bus_bridge_resize() declaration to pci/pci.h
Date: Wed, 12 Mar 2025 15:44:00 -0500 [thread overview]
Message-ID: <20250312204400.GA708146@bhelgaas> (raw)
In-Reply-To: <20250311174701.3586-1-ilpo.jarvinen@linux.intel.com>
On Tue, Mar 11, 2025 at 07:46:58PM +0200, Ilpo Järvinen wrote:
> pci_rescan_bus_bridge_resize() is only used by code inside PCI
> subsystem. The comment also falsely advertizes it to be for hotplug
> drivers, yet the only caller is from sysfs store function. Move the
> function declaration into pci/pci.h.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Applied all four patches to pci/resource for v6.15, thanks, Ilpo!
> ---
> drivers/pci/pci.h | 2 ++
> include/linux/pci.h | 1 -
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> index 01e51db8d285..be2f43c9d3b0 100644
> --- a/drivers/pci/pci.h
> +++ b/drivers/pci/pci.h
> @@ -309,6 +309,8 @@ enum pci_bar_type {
> struct device *pci_get_host_bridge_device(struct pci_dev *dev);
> void pci_put_host_bridge_device(struct device *dev);
>
> +unsigned int pci_rescan_bus_bridge_resize(struct pci_dev *bridge);
> +
> int pci_configure_extended_tags(struct pci_dev *dev, void *ign);
> bool pci_bus_read_dev_vendor_id(struct pci_bus *bus, int devfn, u32 *pl,
> int rrs_timeout);
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 47b31ad724fa..d788acf2686a 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1455,7 +1455,6 @@ void set_pcie_port_type(struct pci_dev *pdev);
> void set_pcie_hotplug_bridge(struct pci_dev *pdev);
>
> /* Functions for PCI Hotplug drivers to use */
> -unsigned int pci_rescan_bus_bridge_resize(struct pci_dev *bridge);
> unsigned int pci_rescan_bus(struct pci_bus *bus);
> void pci_lock_rescan_remove(void);
> void pci_unlock_rescan_remove(void);
>
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> --
> 2.39.5
>
prev parent reply other threads:[~2025-03-12 20:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 17:46 [PATCH 1/4] PCI: Move pci_rescan_bus_bridge_resize() declaration to pci/pci.h Ilpo Järvinen
2025-03-11 17:46 ` [PATCH 2/4] PCI: Move resource reassignment func declarations into pci/pci.h Ilpo Järvinen
2025-03-11 17:47 ` [PATCH 3/4] PCI: Make pci_setup_bridge() static Ilpo Järvinen
2025-03-11 17:47 ` [PATCH 4/4] PCI: Move cardbus IO size declarations into pci/pci.h Ilpo Järvinen
2025-03-12 20:44 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312204400.GA708146@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox