From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bo Sun <Bo.Sun.CN@windriver.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Vidya Sagar <vidyas@nvidia.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Kevin Hao <kexin.hao@windriver.com>,
Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [PATCH v2 2/2] PCI: of_property: Omit 'bus-range' property if no secondary bus
Date: Tue, 18 Mar 2025 11:59:46 +0530 [thread overview]
Message-ID: <20250318062946.2udvt5uryf6y2jmk@thinkpad> (raw)
In-Reply-To: <20250311135229.3329381-3-Bo.Sun.CN@windriver.com>
On Tue, Mar 11, 2025 at 09:52:29PM +0800, Bo Sun wrote:
> The previous implementation of of_pci_add_properties() and
> of_pci_prop_bus_range() assumed that a valid secondary bus is always
> present, which can be problematic in cases where no bus numbers are
> assigned for a secondary bus. This patch introduces a check for a valid
> secondary bus and omits the 'bus-range' property if it is not available,
> preventing dereferencing the NULL pointer.
>
This definitely needs a Fixes tag and should be backported.
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2025-03-18 6:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 13:52 [PATCH v2 0/2] PCI: Marvell CN96XX/CN10XXX quirk and bus-range omission Bo Sun
2025-03-11 13:52 ` [PATCH v2 1/2] PCI: Forcefully set the PCI_REASSIGN_ALL_BUS flag for Marvell CN96XX/CN10XXX boards Bo Sun
2025-03-18 6:27 ` Manivannan Sadhasivam
2025-03-11 13:52 ` [PATCH v2 2/2] PCI: of_property: Omit 'bus-range' property if no secondary bus Bo Sun
2025-03-18 6:29 ` Manivannan Sadhasivam [this message]
2025-03-21 1:17 ` Bo Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250318062946.2udvt5uryf6y2jmk@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=Bo.Sun.CN@windriver.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=kexin.hao@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox