Re: [PATCH 4/7] PCI: endpoint: Add intx_capable to epc_features

[Bjorn Helgaas <helgaas@kernel.org>]

On Mon, Mar 10, 2025 at 12:10:21PM +0100, Niklas Cassel wrote:
> In struct pci_epc_features, an EPC driver can already specify if they
> support MSI (by setting msi_capable) and MSI-X (by setting msix_capable).
> 
> Thus, for consistency, allow an EPC driver to specify if it supports
> INTx interrupts as well (by setting intx_capable).
> 
> Since this struct is zero initialized, EPC drivers that want to claim
> INTx support will need to set intx_capable to true.
> 
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---
>  include/linux/pci-epc.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/pci-epc.h b/include/linux/pci-epc.h
> index 9970ae73c8df..5872652291cc 100644
> --- a/include/linux/pci-epc.h
> +++ b/include/linux/pci-epc.h
> @@ -232,6 +232,7 @@ struct pci_epc_features {
>  	unsigned int	linkup_notifier : 1;
>  	unsigned int	msi_capable : 1;
>  	unsigned int	msix_capable : 1;
> +	unsigned int	intx_capable : 1;

Kernel-doc warning:

  $ find include -name \*pci\* | xargs scripts/kernel-doc -none
  include/linux/pci-epc.h:239: warning: Function parameter or struct member 'intx_capable' not described in 'pci_epc_features'

I'm actually not sure why we merged this, since there's nothing in the
tree that sets intx_capable to anything other than false.  Maybe
there's something coming?

Bjorn