From: Mike Looijmans <mike.looijmans@topic.nl>
To: linux-pci@vger.kernel.org, devicetree@vger.kernel.org
Cc: "Mike Looijmans" <mike.looijmans@topic.nl>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Michal Simek" <michal.simek@amd.com>,
"Rob Herring" <robh@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/3] pcie-xilinx: Support reset GPIO for PERST#
Date: Tue, 25 Mar 2025 08:18:27 +0100 [thread overview]
Message-ID: <20250325071832.21229-3-mike.looijmans@topic.nl> (raw)
In-Reply-To: <20250325071832.21229-1-mike.looijmans@topic.nl>
Support providing the PERST# reset signal through a devicetree binding.
Thus the system no longer relies on external components to perform the
bus reset.
Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---
Changes in v2:
Split into "reset GPIO" and "wait for link" patches
Handle GPIO defer and/or errors
drivers/pci/controller/pcie-xilinx.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/pci/controller/pcie-xilinx.c b/drivers/pci/controller/pcie-xilinx.c
index 2e59b91f43e0..e191ab95d669 100644
--- a/drivers/pci/controller/pcie-xilinx.c
+++ b/drivers/pci/controller/pcie-xilinx.c
@@ -18,6 +18,7 @@
#include <linux/iopoll.h>
#include <linux/msi.h>
#include <linux/of_address.h>
+#include <linux/of_gpio.h>
#include <linux/of_pci.h>
#include <linux/of_platform.h>
#include <linux/of_irq.h>
@@ -577,11 +578,17 @@ static int xilinx_pcie_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct xilinx_pcie *pcie;
struct pci_host_bridge *bridge;
+ struct gpio_desc *perst_gpio;
int err;
if (!dev->of_node)
return -ENODEV;
+ perst_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
+ if (IS_ERR(perst_gpio))
+ return dev_err_probe(dev, PTR_ERR(perst_gpio),
+ "reset-gpios request failed\n");
+
bridge = devm_pci_alloc_host_bridge(dev, sizeof(*pcie));
if (!bridge)
return -ENODEV;
@@ -596,6 +603,13 @@ static int xilinx_pcie_probe(struct platform_device *pdev)
return err;
}
+ if (perst_gpio) {
+ usleep_range(10, 20); /* Assert the reset for ~10 us */
+ gpiod_set_value_cansleep(perst_gpio, 0);
+ /* Initial delay to provide endpoint time to restart */
+ usleep_range(1000, 2000);
+ }
+
xilinx_pcie_init_port(pcie);
err = xilinx_pcie_init_irq_domain(pcie);
--
2.43.0
Met vriendelijke groet / kind regards,
Mike Looijmans
System Expert
TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands
T: +31 (0) 499 33 69 69
E: mike.looijmans@topic.nl
W: www.topic.nl
Please consider the environment before printing this e-mail
next prev parent reply other threads:[~2025-03-25 7:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.aa50e046-9cb9-4d7e-b920-ce2956412b9d@emailsignatures365.codetwo.com>
2025-03-25 7:18 ` [PATCH v2 1/3] pcie-xilinx: Wait for link-up status during initialization Mike Looijmans
2025-03-25 7:18 ` [PATCH v2 2/3] dt-bindings: PCI: xilinx-pcie: Add reset-gpios for PERST# Mike Looijmans
2025-03-25 8:17 ` Krzysztof Kozlowski
2025-03-26 11:57 ` Mike Looijmans
2025-04-02 7:42 ` Manivannan Sadhasivam
2025-03-25 7:18 ` Mike Looijmans [this message]
2025-04-02 7:38 ` [PATCH v2 3/3] pcie-xilinx: Support reset GPIO " Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325071832.21229-3-mike.looijmans@topic.nl \
--to=mike.looijmans@topic.nl \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox