From: Raag Jadav <raag.jadav@intel.com>
To: rafael@kernel.org, mahesh@linux.ibm.com, oohall@gmail.com,
bhelgaas@google.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
ilpo.jarvinen@linux.intel.com, lukas.wunner@intel.com,
Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v1] PCI/AER: Avoid power state transition during system suspend
Date: Thu, 3 Apr 2025 13:14:25 +0530 [thread overview]
Message-ID: <20250403074425.1181053-1-raag.jadav@intel.com> (raw)
If an error is triggered while system suspend is in progress, any bus
level power state transition will result in unpredictable error handling.
Mark skip_bus_pm flag as true to avoid this.
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
Ideally we'd want to defer recovery until system resume, but this is
good enough to prevent device suspend.
More discussion at [1].
[1] https://lore.kernel.org/r/Z-38rPeN_j7YGiEl@black.fi.intel.com
drivers/pci/pcie/aer.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index 508474e17183..5acf4efc2df3 100644
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -1108,6 +1108,12 @@ static void pci_aer_handle_error(struct pci_dev *dev, struct aer_err_info *info)
static void handle_error_source(struct pci_dev *dev, struct aer_err_info *info)
{
+ /*
+ * Avoid any power state transition if an error is triggered during
+ * system suspend.
+ */
+ dev->skip_bus_pm = true;
+
cxl_rch_handle_error(dev, info);
pci_aer_handle_error(dev, info);
pci_dev_put(dev);
--
2.34.1
next reply other threads:[~2025-04-03 7:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 7:44 Raag Jadav [this message]
2025-04-03 18:25 ` [PATCH v1] PCI/AER: Avoid power state transition during system suspend Raag Jadav
2025-04-03 18:35 ` Rafael J. Wysocki
2025-04-04 5:26 ` Raag Jadav
2025-04-04 3:08 ` Lukas Wunner
2025-04-04 5:22 ` Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250403074425.1181053-1-raag.jadav@intel.com \
--to=raag.jadav@intel.com \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas.wunner@intel.com \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox