From: Bjorn Helgaas <helgaas@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Shuah Khan <shuah@kernel.org>, Yi Lai <yi1.lai@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/1] selftests/pcie_bwctrl: Fix test progs list
Date: Thu, 17 Apr 2025 11:42:17 -0500 [thread overview]
Message-ID: <20250417164217.GA114940@bhelgaas> (raw)
In-Reply-To: <20250417124529.11391-1-ilpo.jarvinen@linux.intel.com>
On Thu, Apr 17, 2025 at 03:45:29PM +0300, Ilpo Järvinen wrote:
> The commit df6f8c4d72ae ("selftests/pcie_bwctrl: Add
> 'set_pcie_speed.sh' to TEST_PROGS") added set_pcie_speed.sh into
> TEST_PROGS but that script is a helper that is only being called by
> set_pcie_cooling_state.sh, not a test case itself. When
> set_pcie_speed.sh is in TEST_PROGS, selftest harness will execute also
> it leading to bwctrl selftest errors:
>
> # selftests: pcie_bwctrl: set_pcie_speed.sh
> # cat: /cur_state: No such file or directory
> not ok 2 selftests: pcie_bwctrl: set_pcie_speed.sh # exit=1
>
> Place set_pcie_speed.sh into TEST_FILES instead to have it included
> into installed test files but not execute it from the test harness.
>
> Fixes: df6f8c4d72ae ("selftests/pcie_bwctrl: Add 'set_pcie_speed.sh' to TEST_PROGS")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Applied to pci/for-linus for v6.15, thanks, Ilpo!
> ---
>
> I'm sorry I didn't realize this while the fix was submitted, I'm not that
> familiar with all the kselftest harness variables and the justification
> given for the fix sounded valid enough to raise any alarm bells in my
> mind that something would be off with the approach the fix patch used.
>
> tools/testing/selftests/pcie_bwctrl/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/pcie_bwctrl/Makefile b/tools/testing/selftests/pcie_bwctrl/Makefile
> index 48ec048f47af..277f92f9d753 100644
> --- a/tools/testing/selftests/pcie_bwctrl/Makefile
> +++ b/tools/testing/selftests/pcie_bwctrl/Makefile
> @@ -1,2 +1,3 @@
> -TEST_PROGS = set_pcie_cooling_state.sh set_pcie_speed.sh
> +TEST_PROGS = set_pcie_cooling_state.sh
> +TEST_FILES = set_pcie_speed.sh
> include ../lib.mk
>
> base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
> --
> 2.39.5
>
prev parent reply other threads:[~2025-04-17 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 12:45 [PATCH 1/1] selftests/pcie_bwctrl: Fix test progs list Ilpo Järvinen
2025-04-17 16:42 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417164217.GA114940@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yi1.lai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox