Re: [PATCH] PCI: hotplug: Drop superfluous #include directives

[Bjorn Helgaas <helgaas@kernel.org>]

On Thu, Apr 17, 2025 at 09:30:40PM +0200, Lukas Wunner wrote:
> On Tue, Apr 15, 2025 at 03:33:54PM -0500, Bjorn Helgaas wrote:
> > On Mon, Apr 14, 2025 at 04:25:21PM +0200, Lukas Wunner wrote:
> > > In February 2003, historic commit
> > > 
> > >   https://git.kernel.org/tglx/history/c/280c1c9a0ea4
> > >   ("[PATCH] PCI Hotplug: Replace pcihpfs with sysfs.")
> > > 
> > > removed all invocations of __get_free_page() and free_page() from the
> > > PCI hotplug core without also removing the #include <linux/pagemap.h>
> > > directive.
> > > 
> > > It removed all invocations of kern_mount(), mntget() and mntput()
> > > without also removing the #include <linux/mount.h> directive.
> > > 
> > > It removed all invocations of lookup_hash()
> > > without also removing the #include <linux/namei.h> directive.
> > > 
> > > It removed all invocations of copy_to_user() and copy_from_user()
> > > without also removing the #include <linux/uaccess.h> directive.
> > > 
> > > These #include directives are still unnecessary today, so drop them.
> > > 
> > > Signed-off-by: Lukas Wunner <lukas@wunner.de>
> > 
> > Applied to pci/hotplug for v6.16, thanks!
> 
> A small issue snuck into the commit message while applying:
> 
> There's a sentence which ends abruptly:
> 
>     It removed all invocations of lookup_hash() without also removing the
> 
> The remainder of the sentence should have been:
> 
>     #include <linux/namei.h> directive.
> 
> While rewrapping the paragraph, the word "#ifdef" ended up at the
> beginning of the line and "git commit" interpreted that as a comment
> and stripped the line from the commit message.

Wow, thanks for noticing that.  That's new to me.  I this I restored
it.