From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4FB1289367 for ; Wed, 23 Apr 2025 18:02:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745431343; cv=none; b=qY36+OR/ySjkFpX+BqTaWBaPLt0Fl9YOJxZRsU8qPot+FyY16PqdkMqcmls3b4CWZNPafM6WdLXIRSyXNwUbfcPK1XJqWC1iJJzo4AprovXvuZ6ZOddNNPjuQDSm+PXot55kUEyy3/2U4ou+z7ZgdajNxIVc8WMaWecg57CbMtU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745431343; c=relaxed/simple; bh=jMGBnlKKS3wriE0M2t3GS1b7w0yLhTPXvhMeTWbbHrA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KdONRS+ZJSZ2zk6COyZSxE2ZoaElQhK370dSgF/Mc99josyY97G+Q4mr5d/JT+mmN0+LnC5uS8cV3mnGzC2m4SvkSgj2Kqp3OY65oT0lZGnUbgPPxWUPVoQwcXdAeOHyGb5RGaLz3G5tNr7QbzsOZvJNRdrgIdcltj26uWCvK3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=oME2bGbG; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="oME2bGbG" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6ecf99dd567so2240636d6.0 for ; Wed, 23 Apr 2025 11:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1745431340; x=1746036140; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v/H5CAwHQKAGhhgyjSbvaHcVayhHkcFdusJoJuYFxH8=; b=oME2bGbGIz+n8qPmjxlLjGtl64CvjZEPLK7vic6PtKju9KvsD8hbQoAkwLgEIUXBXg iqMA9uiI8nIhmBox8Z7ZtsEVF9rde1sOPnx8+Ic/YkmuJ9mTOLkrk722E5IWEIRNAYGR CVnGLdLxvEKtC2PTbivi1fVVAU/xnbJH1e3h1aYaD6xXqyyQUWxXFa7Xe/FlDmqtEMBh M2vt6LSy6VXOVecd3pdAWZPlsCrclj/UmngB8o9ubhNBU5XVxQpZ9ogcCm6n3z5DL56T 4rghcIF1xc2841w2V+rvve+AZ1efnzAOOk4mZhF4CMwBHIR6quQkjZVOdYpgnKUYZnoy QpAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745431340; x=1746036140; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v/H5CAwHQKAGhhgyjSbvaHcVayhHkcFdusJoJuYFxH8=; b=pFgFQrnhyjhx3YV/x5hVyntRi/QN81py8jTJvVNEGP3JFv7azJWnO6lBqssc3Wv9p8 gLDNSfHnnaHu337zTfjCcF3wLhecUu5Ps5XorDPqAoPpR1b0GJWk8l1ntesbhQYczkmI ay+53wdu+CdNRuWWLWOVjE5ktllkDdswY4qiMSzcl/WRp/XzQSF5b+2f3o+yq8ptbXCp DTTGQJ3YWiH1VqmuEKrBcuwj24Ld2TzNFuT7/EBhE+Gbf8DlAYBQS7oJUqVIvK8p8q0T XacYtFsD1obYIiw7RJTSciVFMuQgtKR+5YyYjca2GK23ygBhnLZcqtKLVirXHqEGQ/7x kjJw== X-Forwarded-Encrypted: i=1; AJvYcCXCXEwVcK+weOF3oe5ilhg+njyLGoHja3s7QoNljLn17NK1jCrubrWPGMcVqvpn5GBI0AzPpBlrpyE=@vger.kernel.org X-Gm-Message-State: AOJu0YzwiT6q+o1nQ1+EiNOjg/EPFhDidNX+Wkoy8xxOGkql6ncbq509 rpTdsYh/MBva5YXfN701Y6kDq/OCAPHsF4+xAtW/h5+A7atwdqijInvTUZ7wMFc= X-Gm-Gg: ASbGnctnvZy7SunJa26UYgHK5erNhRfy/IiFm1ZBsNziKJET0of8SnT7Eu68hLKTMMu zWdJhumN2qWoRa8c2LhI3t0Y0PDbo0FywJ1MKOHdbhglsXhTLQFU61MkpioZclZuLggQK/tjmEY wfe5QnU4hSgBQnekWlUd/ZQomcFIpY0FNj6wyWwQKEgPRUplDtuiZffbL6u1rg4+SOTKCl3XZPj dk3idXssbmki8hNyEIT+2fuAMKAF98GW85dyn8QjIEwExJ4P2Ct2PRE9whdjDsVQvT3ZsFB4vdg oGVZLYeaEOHiqsv74HDWjApRNm2OmIrThmi47t9oqU6Isy54Atea9slFuIyLbgOgmRdjjbUzQrS 6pcL5iHrIFw+lE+g9Vn0= X-Google-Smtp-Source: AGHT+IHxXzsMEe6MN5UQygppndiI4ddaFnTKWUy8FtozhFzNSVoZsB8f3DMDl3MfRyMHEIrbMun+Mw== X-Received: by 2002:a05:6214:19c8:b0:6ee:ba58:e099 with SMTP id 6a1803df08f44-6f2c454e522mr330593466d6.15.1745431340219; Wed, 23 Apr 2025 11:02:20 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-219-86.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.219.86]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f2c2c3ba3fsm73300796d6.125.2025.04.23.11.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 11:02:19 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1u7eQN-00000007LrM-0sGN; Wed, 23 Apr 2025 15:02:19 -0300 Date: Wed, 23 Apr 2025 15:02:19 -0300 From: Jason Gunthorpe To: Leon Romanovsky Cc: Marek Szyprowski , Jens Axboe , Christoph Hellwig , Keith Busch , Leon Romanovsky , Jake Edge , Jonathan Corbet , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni Subject: Re: [PATCH v9 16/24] vfio/mlx5: Rewrite create mkey flow to allow better code reuse Message-ID: <20250423180219.GR1213339@ziepe.ca> References: Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Apr 23, 2025 at 11:13:07AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Change the creation of mkey to be performed in multiple steps: > data allocation, DMA setup and actual call to HW to create that mkey. > > In this new flow, the whole input to MKEY command is saved to eliminate > the need to keep array of pointers for DMA addresses for receive list > and in the future patches for send list too. > > In addition to memory size reduce and elimination of unnecessary data > movements to set MKEY input, the code is prepared for future reuse. > > Tested-by: Jens Axboe > Signed-off-by: Leon Romanovsky > --- > drivers/vfio/pci/mlx5/cmd.c | 157 ++++++++++++++++++++---------------- > drivers/vfio/pci/mlx5/cmd.h | 4 +- > 2 files changed, 91 insertions(+), 70 deletions(-) Reviewed-by: Jason Gunthorpe Jason