Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Ryan Matthews <ryanmatthews@fastmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Richard Zhu <hongxing.zhu@nxp.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	stable@vger.kernel.org, linux-pci@vger.kernel.org,
	Ryan Matthews <ryanmatthews@fastmail.com>
Subject: [PATCH 6.6 1/2] Revert "PCI: imx6: Skip controller_id generation logic for i.MX7D"
Date: Sun,  4 May 2025 15:13:55 -0400	[thread overview]
Message-ID: <20250504191356.17732-2-ryanmatthews@fastmail.com> (raw)
In-Reply-To: <20250504191356.17732-1-ryanmatthews@fastmail.com>

This reverts commit 2a12efc567a270a155e3b886258297abd79cdea0 which is
commit f068ffdd034c93f0c768acdc87d4d2d7023c1379 upstream.

This is a backport mistake.

Deleting "IMX7D" here skips more than just controller_id logic. It skips
reset assignments too, which causes:

 imx6q-pcie 33800000.pcie: PCIe PLL lock timeout

In my case, in addition to broken PCIe, kernel boot hangs entirely.

This isn't a problem upstream because before this, they moved the rest of
the code out of the switch case.

Signed-off-by: Ryan Matthews <ryanmatthews@fastmail.com>
---
 drivers/pci/controller/dwc/pci-imx6.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 822a750b064b..20c8f2cba453 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1281,6 +1281,7 @@ static int imx6_pcie_probe(struct platform_device *pdev)
 	switch (imx6_pcie->drvdata->variant) {
 	case IMX8MQ:
 	case IMX8MQ_EP:
+	case IMX7D:
 		if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR)
 			imx6_pcie->controller_id = 1;
 
-- 
2.47.2


  reply	other threads:[~2025-05-04 19:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-04 19:13 [PATCH 6.6 0/2] PCI: imx6: Fix i.MX7D controller_id backport regression Ryan Matthews
2025-05-04 19:13 ` Ryan Matthews [this message]
2025-05-04 19:13 ` [PATCH 6.6 2/2] PCI: imx6: Skip controller_id generation logic for i.MX7D Ryan Matthews
2025-05-05  9:23 ` [PATCH 6.6 0/2] PCI: imx6: Fix i.MX7D controller_id backport regression Greg Kroah-Hartman
2025-05-06  5:42   ` [PATCH 6.1 0/1] " Ryan Matthews
2025-05-06  5:42     ` [PATCH 6.1 1/1] PCI: imx6: Skip controller_id generation logic for i.MX7D Ryan Matthews
2025-05-06  5:44   ` [PATCH 5.4 0/1] PCI: imx6: Fix i.MX7D controller_id backport regression Ryan Matthews
2025-05-06  5:44     ` [PATCH 5.4 1/1] PCI: imx6: Skip controller_id generation logic for i.MX7D Ryan Matthews

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250504191356.17732-2-ryanmatthews@fastmail.com \
    --to=ryanmatthews@fastmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hongxing.zhu@nxp.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-pci@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox