Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Ammar Qadri <ammarq@google.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Ammar Qadri <ammarq@google.com>
Subject: [PATCH] PCI: Reduce verbosity of device enable messages
Date: Wed,  7 May 2025 23:29:19 +0000	[thread overview]
Message-ID: <20250507232919.801801-1-ammarq@google.com> (raw)

Excessive logging of PCIe device enable operations can create significant
noise in system logs, especially in environments with a high number of
such devices, especially VFs.

High-rate logging can cause log files to rotate too quickly, losing
valuable information from other system components.This commit addresses
this issue by downgrading the logging level of "enabling device" messages
from `info` to `dbg`.

Signed-off-by: Ammar Qadri <ammarq@google.com>
---
 drivers/pci/setup-res.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
index c6657cdd06f67..be669ff6ca240 100644
--- a/drivers/pci/setup-res.c
+++ b/drivers/pci/setup-res.c
@@ -516,7 +516,7 @@ int pci_enable_resources(struct pci_dev *dev, int mask)
 	}
 
 	if (cmd != old_cmd) {
-		pci_info(dev, "enabling device (%04x -> %04x)\n", old_cmd, cmd);
+		pci_dbg(dev, "enabling device (%04x -> %04x)\n", old_cmd, cmd);
 		pci_write_config_word(dev, PCI_COMMAND, cmd);
 	}
 	return 0;
-- 
2.49.0.987.g0cc8ee98dc-goog


             reply	other threads:[~2025-05-07 23:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-07 23:29 Ammar Qadri [this message]
2025-06-13  6:12 ` [PATCH] PCI: Reduce verbosity of device enable messages Manivannan Sadhasivam
2025-06-13 21:40   ` Ammar Qadri
2025-06-13 22:09     ` Bjorn Helgaas
2025-07-09 18:25       ` Ammar Qadri
2025-07-09 20:26         ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250507232919.801801-1-ammarq@google.com \
    --to=ammarq@google.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox