Linux PCI subsystem development
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Paul E . McKenney" <paulmck@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Lukas Wunner" <lukas@wunner.de>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] PCI/bwctrl: Remove also pcie_bwctrl_lbms_rwsem
Date: Thu,  8 May 2025 12:00:36 +0300	[thread overview]
Message-ID: <20250508090036.1528-1-ilpo.jarvinen@linux.intel.com> (raw)

The commit 0238f352a63a ("PCI/bwctrl: Replace lbms_count with
PCI_LINK_LBMS_SEEN flag") remove all code related to
pcie_bwctrl_lbms_rwsem but forgot to remove the rwsem itself.
Remove it and the associated info from the comment now.

Fixes: 0238f352a63a ("PCI/bwctrl: Replace lbms_count with PCI_LINK_LBMS_SEEN flag")
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---

Bjorn, this should be folded into the original commit I think.

 drivers/pci/pcie/bwctrl.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/pci/pcie/bwctrl.c b/drivers/pci/pcie/bwctrl.c
index fdafa20e4587..f31fbbd51490 100644
--- a/drivers/pci/pcie/bwctrl.c
+++ b/drivers/pci/pcie/bwctrl.c
@@ -45,15 +45,7 @@ struct pcie_bwctrl_data {
 	struct thermal_cooling_device *cdev;
 };
 
-/*
- * Prevent port removal during LBMS count accessors and Link Speed changes.
- *
- * These have to be differentiated because pcie_bwctrl_change_speed() calls
- * pcie_retrain_link() which uses LBMS count reset accessor on success
- * (using just one rwsem triggers "possible recursive locking detected"
- * warning).
- */
-static DECLARE_RWSEM(pcie_bwctrl_lbms_rwsem);
+/* Prevent port removal during Link Speed changes. */
 static DECLARE_RWSEM(pcie_bwctrl_setspeed_rwsem);
 
 static bool pcie_valid_speed(enum pci_bus_speed speed)

base-commit: 0238f352a63a075ac1f35ea565b5bec3057ec8bd
-- 
2.39.5


             reply	other threads:[~2025-05-08  9:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-08  9:00 Ilpo Järvinen [this message]
2025-05-08 15:14 ` [PATCH 1/1] PCI/bwctrl: Remove also pcie_bwctrl_lbms_rwsem Paul E. McKenney
2025-05-14 17:28 ` Krzysztof Wilczyński
2025-05-14 19:42   ` Lukas Wunner
2025-05-15  8:43     ` Krzysztof Wilczyński
2025-05-15 12:09       ` Lukas Wunner
2025-05-15 12:21         ` Ilpo Järvinen
2025-05-15 12:33           ` Lukas Wunner
2025-05-15 14:00             ` Krzysztof Wilczy??ski
2025-05-15 14:05               ` Krzysztof Wilczy??ski
2025-05-15 13:54           ` Krzysztof Wilczy??ski
2025-05-15 13:51         ` Krzysztof Wilczy??ski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250508090036.1528-1-ilpo.jarvinen@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=paulmck@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox