From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BF8F259C8B; Wed, 21 May 2025 09:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747820813; cv=none; b=d3FZr3qwu7Styo57f1Y+43CqOtJoKcKxTv9JD9FA34kHJr//yKz5zI0PcMbYndSBcbTVNoVrz6h5rAy0SH1vpvqDII2VfgI7ia8EHG+m3GtKcE8RdvnHujKlCixqS88gCBrma+mtKYMdXPpzH4RpiKD4+q1f5+R8iEQ9/GtmNKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747820813; c=relaxed/simple; bh=bALurWINeemsS9FiIXF+On7FsR1xn9Mw25SoEzfSt0U=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DXr2AHEd6lrn47Z9Yy9+jT3Di6FW9IqMgDSW1WgHhH/HyZb5SJGqi7zMeVM8CAPWChr5Gjon1nMvfihN8mcL3uKU1KtzH0xmmFPDyFviLJCpNphF+hwjdEIfTZEDyj7kbR9kfIT+leZdYHgCXkuVDzJpRS0WWuoRoDC/JMP7XmE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4b2RK14kKNz6D9ct; Wed, 21 May 2025 17:41:57 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id D890F1404F4; Wed, 21 May 2025 17:46:48 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 21 May 2025 11:46:44 +0200 Date: Wed, 21 May 2025 10:46:42 +0100 From: Jonathan Cameron To: Bjorn Helgaas CC: , Jon Pan-Doh , "Karolina Stolarek" , Weinan Liu , Martin Petersen , Ben Fuller , Drew Walton , "Anil Agrawal" , Tony Luck , Ilpo =?UTF-8?Q?J=C3=A4rvinen?= , "Sathyanarayanan Kuppuswamy" , Lukas Wunner , Sargun Dhillon , "Paul E . McKenney" , Mahesh J Salgaonkar , "Oliver O'Halloran" , Kai-Heng Feng , "Keith Busch" , Robert Richter , Terry Bowman , Shiju Jose , Dave Jiang , , , Bjorn Helgaas , Krzysztof =?UTF-8?Q?Wilczy=C5=84ski?= Subject: Re: [PATCH v7 11/17] PCI/AER: Combine trace_aer_event() with statistics updates Message-ID: <20250521104642.00003648@huawei.com> In-Reply-To: <20250520215047.1350603-12-helgaas@kernel.org> References: <20250520215047.1350603-1-helgaas@kernel.org> <20250520215047.1350603-12-helgaas@kernel.org> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: lhrpeml100003.china.huawei.com (7.191.160.210) To frapeml500008.china.huawei.com (7.182.85.71) On Tue, 20 May 2025 16:50:28 -0500 Bjorn Helgaas wrote: > From: Bjorn Helgaas >=20 > As with the AER statistics, we always want to emit trace events, even if > the actual dmesg logging is rate limited. >=20 > Call trace_aer_event() directly from pci_dev_aer_stats_incr(), where we > update the statistics. >=20 > Signed-off-by: Bjorn Helgaas > Tested-by: Krzysztof Wilczy=C5=84ski > Reviewed-by: Ilpo J=C3=A4rvinen > Reviewed-by: Kuppuswamy Sathyanarayanan Hmm. This runs a bit counter to what I liked in previous patch. Whilst convenient to issue trace points in the stats update function it's not obvious behavior given naming. Maybe just duplicate the call and call it immediately after the pci_dev_aer_stats_incr() calls? > --- > drivers/pci/pcie/aer.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c > index 53b7559564a9..ec63825a808e 100644 > --- a/drivers/pci/pcie/aer.c > +++ b/drivers/pci/pcie/aer.c > @@ -625,6 +625,9 @@ static void pci_dev_aer_stats_incr(struct pci_dev *pd= ev, > u64 *counter =3D NULL; > struct aer_stats *aer_stats =3D pdev->aer_stats; > =20 > + trace_aer_event(pci_name(pdev), (info->status & ~info->mask), > + info->severity, info->tlp_header_valid, &info->tlp); > + > if (!aer_stats) > return; > =20 > @@ -741,9 +744,6 @@ void aer_print_error(struct pci_dev *dev, struct aer_= err_info *info) > out: > if (info->id && info->error_dev_num > 1 && info->id =3D=3D id) > pci_err(dev, " Error of this Agent is reported first\n"); > - > - trace_aer_event(dev_name(&dev->dev), (info->status & ~info->mask), > - info->severity, info->tlp_header_valid, &info->tlp); > } > =20 > #ifdef CONFIG_ACPI_APEI_PCIEAER > @@ -782,6 +782,9 @@ void pci_print_aer(struct pci_dev *dev, int aer_sever= ity, > =20 > info.status =3D status; > info.mask =3D mask; > + info.tlp_header_valid =3D tlp_header_valid; > + if (tlp_header_valid) > + info.tlp =3D aer->header_log; > =20 > pci_dev_aer_stats_incr(dev, &info); > =20 > @@ -799,9 +802,6 @@ void pci_print_aer(struct pci_dev *dev, int aer_sever= ity, > =20 > if (tlp_header_valid) > pcie_print_tlp_log(dev, &aer->header_log, dev_fmt(" ")); > - > - trace_aer_event(pci_name(dev), (status & ~mask), > - aer_severity, tlp_header_valid, &aer->header_log); > } > EXPORT_SYMBOL_NS_GPL(pci_print_aer, "CXL"); > =20