From: Leon Romanovsky <leon@kernel.org>
To: grwhyte@linux.microsoft.com
Cc: linux-pci@vger.kernel.org, shyamsaini@linux.microsoft.com,
code@tyhicks.com, Okaya@kernel.org, bhelgaas@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Reduce delay after FLR of Microsoft MANA devices
Date: Thu, 22 May 2025 11:52:53 +0300 [thread overview]
Message-ID: <20250522085253.GN7435@unreal> (raw)
In-Reply-To: <20250521231539.815264-1-grwhyte@linux.microsoft.com>
On Wed, May 21, 2025 at 11:15:39PM +0000, grwhyte@linux.microsoft.com wrote:
> From: Graham Whyte <grwhyte@linux.microsoft.com>
>
> Add a device-specific reset for Microsoft MANA devices with the FLR
> delay reduced from 100ms to 10ms. While this is not compliant with the pci
> spec, these devices safely complete the FLR much quicker than 100ms and
> this can be reduced to optimize certain scenarios
>
> Signed-off-by: Graham Whyte <grwhyte@linux.microsoft.com>
> ---
> drivers/pci/pci.c | 3 ++-
> drivers/pci/pci.h | 1 +
> drivers/pci/quirks.c | 55 ++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 58 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 9cb1de7658b5..ad2960117acd 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -1262,7 +1262,7 @@ void pci_resume_bus(struct pci_bus *bus)
> pci_walk_bus(bus, pci_resume_one, NULL);
> }
>
> -static int pci_dev_wait(struct pci_dev *dev, char *reset_type, int timeout)
> +int pci_dev_wait(struct pci_dev *dev, char *reset_type, int timeout)
> {
> int delay = 1;
> bool retrain = false;
> @@ -1344,6 +1344,7 @@ static int pci_dev_wait(struct pci_dev *dev, char *reset_type, int timeout)
>
> return 0;
> }
> +EXPORT_SYMBOL_GPL(pci_dev_wait);
pci.c and quirks.c can't built as independent modules. There is no need
in EXPORT_SYMBOL_GPL here.
Thanks
next prev parent reply other threads:[~2025-05-22 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 23:15 [PATCH] PCI: Reduce delay after FLR of Microsoft MANA devices grwhyte
2025-05-22 8:52 ` Leon Romanovsky [this message]
2025-05-23 16:39 ` Bjorn Helgaas
2025-05-27 18:14 ` Graham Whyte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250522085253.GN7435@unreal \
--to=leon@kernel.org \
--cc=Okaya@kernel.org \
--cc=bhelgaas@google.com \
--cc=code@tyhicks.com \
--cc=grwhyte@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=shyamsaini@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).