From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com [136.143.188.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4054E2D1F69; Thu, 12 Jun 2025 18:58:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.12 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749754722; cv=pass; b=BhnDHM6AIhmhXQAgEpuhxnHzfFZBo7S3/Lo4BB9N2iP2XOUesAz+Iqx3CRZyGYl31zoiPIjwz0RbZE6h3eC1TuC3Rl8anL0Lc8uEhxKzMk+TRsyxAsw0a3A9xMI7PCbj7AnYOK2dT9otAD1ok56v+ygY4pKqzPAIza1345ef0Ew= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749754722; c=relaxed/simple; bh=H7aXCdbydtZ89HoSF13f+y9lt7yH7Xn+GU4gM/yYLrw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gyphEmSqDXPDbMwGECueEylRmFWNchuTnJIxruEKiZpUq1BAOLf7zMVQtlmd08zmxinHrM7Cbyo8GImJ57VMr0bWF72g7nEIqB7elNJ3Ly2AyTEONqLEL9Y6pY7Qp6s3KupsoeO+2exNI+vA2ugM3FLZHM/JxnnEsPr+xrcbt30= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=A+wttCJo; arc=pass smtp.client-ip=136.143.188.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="A+wttCJo" ARC-Seal: i=1; a=rsa-sha256; t=1749754663; cv=none; d=zohomail.com; s=zohoarc; b=VIVSWUHUDhSyIr5VPzQQv7abH/sQyPr4VEfvrq+pf3y6T5ctXdGUOylcpl/6KZuCw9m683oiY0ct+1c/CxDhO+LyoSAbhwwcy5dBnlArU+Qeiu2wH3S7shTBpQIj/EvKWckVkoQHk4TO5+jCms97x5gPlmdDBkBHLrTt1crpXio= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749754663; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=JRCZRQ76GcMlJmExs7D12cB0k3smTmlvVSyjx4WGW5s=; b=ntaiHlvBA+A7Xq20rx7nJXFZhB+l92gqFbKwWc6afm304WhD5PHHeD8GKFYJub4iUhUmNilDW41HpWtA1dCq1DkviyiVG59OpEh1ovNOkGGmCJ8SZvYo/Igu12+n98zzfmNqGIlbP5cBWPtxuFuw/XPNuIejOVfbU4fjcz3IlJY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1749754663; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=JRCZRQ76GcMlJmExs7D12cB0k3smTmlvVSyjx4WGW5s=; b=A+wttCJo4137gNw9pr1C972PU7mQ5agBkbjRzFLtDwzcJjdTeN9JI8TBCXZwgtpr PwBGFHka5M54F99jMHceL9KyQUu+yao+8mCy1PsU69P1c8eWkm4xZVtTyS9Qye/6R3p 7Yayt7oUjNH3tT8mrddNiQXazittftRIxkVoiA+s= Received: by mx.zohomail.com with SMTPS id 17497546627841003.7575879427058; Thu, 12 Jun 2025 11:57:42 -0700 (PDT) From: Nicolas Frattaroli Date: Thu, 12 Jun 2025 20:56:08 +0200 Subject: [PATCH 06/20] phy: rockchip-emmc: switch to HWORD_UPDATE macro Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250612-byeword-update-v1-6-f4afb8f6313f@collabora.com> References: <20250612-byeword-update-v1-0-f4afb8f6313f@collabora.com> In-Reply-To: <20250612-byeword-update-v1-0-f4afb8f6313f@collabora.com> To: Yury Norov , Rasmus Villemoes , Jaehoon Chung , Ulf Hansson , Heiko Stuebner , Shreeya Patel , Mauro Carvalho Chehab , Sandy Huang , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Vinod Koul , Kishon Vijay Abraham I , Nicolas Frattaroli , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Shawn Lin , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Qin Jian , Michael Turquette , Stephen Boyd , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, llvm@lists.linux.dev, Nicolas Frattaroli X-Mailer: b4 0.14.2 The era of hand-rolled HIWORD_UPDATE macros is over, at least for those drivers that use constant masks. Replace the implementation of the rockchip eMMC PHY driver's HIWORD_UPDATE macro with bitfield.h's HWORD_UPDATE. This makes the change more easily reviewable. Signed-off-by: Nicolas Frattaroli --- drivers/phy/rockchip/phy-rockchip-emmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy/rockchip/phy-rockchip-emmc.c index 20023f6eb9944eaab505101d57e806476ecfac71..42423d4cd1811cd039a701895758050483d1c959 100644 --- a/drivers/phy/rockchip/phy-rockchip-emmc.c +++ b/drivers/phy/rockchip/phy-rockchip-emmc.c @@ -6,6 +6,7 @@ * Copyright (C) 2016 ROCKCHIP, Inc. */ +#include #include #include #include @@ -21,7 +22,7 @@ * only if BIT(x + 16) set to 1 the BIT(x) can be written. */ #define HIWORD_UPDATE(val, mask, shift) \ - ((val) << (shift) | (mask) << ((shift) + 16)) + (HWORD_UPDATE((mask) << (shift), (val))) /* Register definition */ #define GRF_EMMCPHY_CON0 0x0 -- 2.49.0