From: Bjorn Helgaas <helgaas@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH] pci: pwrctl: fix the kerneldoc tag for private fields
Date: Mon, 23 Jun 2025 13:10:42 -0500 [thread overview]
Message-ID: <20250623181042.GA1436011@bhelgaas> (raw)
In-Reply-To: <20250618091129.44810-1-brgl@bgdev.pl>
On Wed, Jun 18, 2025 at 11:11:29AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The correct tag for marking private fields in kerneldoc is "private:",
> not capitalized "Private:". Fix the pwrctl struct to silence the
> following warnings:
>
> Warning: include/linux/pci-pwrctrl.h:45 struct member 'nb' not described in 'pci_pwrctrl'
> Warning: include/linux/pci-pwrctrl.h:45 struct member 'link' not described in 'pci_pwrctrl'
> Warning: include/linux/pci-pwrctrl.h:45 struct member 'work' not described in 'pci_pwrctrl'
>
> Fixes: 4565d2652a37 ("PCI/pwrctl: Add PCI power control core code")
> Reported-by: Bjorn Helgaas <helgaas@kernel.org>
> Closes: https://lore.kernel.org/all/20250617233539.GA1177120@bhelgaas/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Applied to pci/pwrctrl for v6.17, thanks!
> ---
> include/linux/pci-pwrctrl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/pci-pwrctrl.h b/include/linux/pci-pwrctrl.h
> index 7d439b0675e9..4aefc7901cd1 100644
> --- a/include/linux/pci-pwrctrl.h
> +++ b/include/linux/pci-pwrctrl.h
> @@ -39,7 +39,7 @@ struct device_link;
> struct pci_pwrctrl {
> struct device *dev;
>
> - /* Private: don't use. */
> + /* private: internal use only */
> struct notifier_block nb;
> struct device_link *link;
> struct work_struct work;
> --
> 2.48.1
>
prev parent reply other threads:[~2025-06-23 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 9:11 [PATCH] pci: pwrctl: fix the kerneldoc tag for private fields Bartosz Golaszewski
2025-06-23 18:10 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250623181042.GA1436011@bhelgaas \
--to=helgaas@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox