From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4A7A248F59 for ; Tue, 24 Jun 2025 08:21:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750753316; cv=none; b=sF3pMwXlSdVfSqzn8oAbPR9vLIeXu8Jl9MbFCP3+SVha7X2bdOirMur7yPoWEt2Md/TMkT1WFD4/ABEj8bvDtavJVqjt29C9o1BFrmQBlSxQSvnZcl9tX/EiwSJTjLWOk9SrkON/OQhkfZEnV8uzWZiZzPzjPOw7TYYQeY/JyBs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750753316; c=relaxed/simple; bh=ELNzgUsnz50PUcMg9lufDyWgRyzoPrXHNhYtOrfILcE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sdVJUs79U5CkWr3TzBCjNroEyhSD1UIrHAwN/D/LeUV1vnAhn2Y89GD76EiK0MGXHIpGKdYL6BAfE1e6tLKrhnyXdd3gyluiKTUD7LTatB9cwCX0NS6sgKxPPzq9Z8cYBTe60RV5JF7e+t2atZzU5PqBCfAbfgQkeAlkpvJs28A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NGytPESn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NGytPESn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE5A1C4CEF1; Tue, 24 Jun 2025 08:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750753315; bh=ELNzgUsnz50PUcMg9lufDyWgRyzoPrXHNhYtOrfILcE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NGytPESn/esmkgkJwq2EGMp7sc3OZQLueF2EtXnPSZtnIvVf2F9kVmnSRg2K/WQ2s Hn0eu/YPBGQnI848qNU+JmESiEhBuEoM3/PsUEizugX+1vETNyjH85FPgOwhzdQbpy SADw+9w6dzVPa65D2UrRwubIXmNmSUnUcbmbw2pkS6tuyBsgcnIWhgS1PrF3BwESMA XudO8KVC5OAmYet9DxCQXebzid5l4wq+xqXwAOAQa23lhcyJ73QvzMO3qom5A838Lw rBs7nuROisWT8UZUbmu0LwumzTbDgkaAaKNjzIRTGa/KUzF9dcgUWSZgxSPdZxPj+s /8PeBMl9Er+6Q== From: Damien Le Moal To: linux-pci@vger.kernel.org, Manivannan Sadhasivam , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas Cc: Niklas Cassel Subject: [PATCH v2 1/2] PCI: endpoint: Fix configfs group list head handling Date: Tue, 24 Jun 2025 17:19:48 +0900 Message-ID: <20250624081949.289664-2-dlemoal@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250624081949.289664-1-dlemoal@kernel.org> References: <20250624081949.289664-1-dlemoal@kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Doing a list_del() on the epf_group field of struct pci_epf_driver in pci_epf_remove_cfs() is not correct as this field is a list head, not a list entry. This list_del() call triggers a KASAN warning when an endpoint function driver which has a configfs attribute group is torn down: ================================================================== BUG: KASAN: slab-use-after-free in pci_epf_remove_cfs+0x17c/0x198 Write of size 8 at addr ffff00010f4a0d80 by task rmmod/319 CPU: 3 UID: 0 PID: 319 Comm: rmmod Not tainted 6.16.0-rc2 #1 NONE Hardware name: Radxa ROCK 5B (DT) Call trace: show_stack+0x2c/0x84 (C) dump_stack_lvl+0x70/0x98 print_report+0x17c/0x538 kasan_report+0xb8/0x190 __asan_report_store8_noabort+0x20/0x2c pci_epf_remove_cfs+0x17c/0x198 pci_epf_unregister_driver+0x18/0x30 nvmet_pci_epf_cleanup_module+0x24/0x30 [nvmet_pci_epf] __arm64_sys_delete_module+0x264/0x424 invoke_syscall+0x70/0x260 el0_svc_common.constprop.0+0xac/0x230 do_el0_svc+0x40/0x58 el0_svc+0x48/0xdc el0t_64_sync_handler+0x10c/0x138 el0t_64_sync+0x198/0x19c ... Remove this incorrect list_del() call from pci_epf_remove_cfs(). Fixes: ef1433f717a2 ("PCI: endpoint: Create configfs entry for each pci_epf_device_id table entry") Cc: stable@vger.kernel.org Signed-off-by: Damien Le Moal --- drivers/pci/endpoint/pci-epf-core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c index 577a9e490115..defc6aecfdef 100644 --- a/drivers/pci/endpoint/pci-epf-core.c +++ b/drivers/pci/endpoint/pci-epf-core.c @@ -338,7 +338,6 @@ static void pci_epf_remove_cfs(struct pci_epf_driver *driver) mutex_lock(&pci_epf_mutex); list_for_each_entry_safe(group, tmp, &driver->epf_group, group_entry) pci_ep_cfs_remove_epf_group(group); - list_del(&driver->epf_group); mutex_unlock(&pci_epf_mutex); } -- 2.49.0