From: Joel Fernandes <joelagnelf@nvidia.com>
To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
linux-pci@vger.kernel.org, dakr@kernel.org
Cc: acourbot@nvidia.com, "Alistair Popple" <apopple@nvidia.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"John Hubbard" <jhubbard@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>,
joel@joelfernandes.org,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>
Subject: [PATCH] rust: pci: add PCI interrupt allocation and management support
Date: Tue, 9 Sep 2025 23:54:15 -0400 [thread overview]
Message-ID: <20250910035415.381753-1-joelagnelf@nvidia.com> (raw)
Add support for allocating and managing PCI interrupts (MSI-X, MSI, and
legacy) in the Rust PCI abstractions. This provides an interface for
drivers to allocate interrupt vectors and obtain their Linux IRQ
numbers.
Add the following methods to PCI device:
- alloc_irq_vectors() for allocating interrupts during probe
- irq_vector() for obtaining Linux IRQ numbers for each vector
- free_irq_vectors() for releasing interrupt resources during unbind
This is required for Nova's IRQ handling to allocate and manage
interrupts using PCI interrupt APIs.
Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
---
rust/kernel/pci.rs | 131 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 131 insertions(+)
diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs
index 887ee611b553..98c3a7a04e88 100644
--- a/rust/kernel/pci.rs
+++ b/rust/kernel/pci.rs
@@ -23,6 +23,59 @@
};
use kernel::prelude::*;
+/// IRQ type flags for PCI interrupt allocation.
+#[derive(Debug, Clone, Copy)]
+pub enum IrqType {
+ /// Legacy INTx interrupts
+ Legacy,
+ /// Message Signaled Interrupts (MSI)
+ Msi,
+ /// Extended Message Signaled Interrupts (MSI-X)
+ MsiX,
+}
+
+impl IrqType {
+ /// Convert to the corresponding kernel flags
+ const fn to_flags(self) -> u32 {
+ match self {
+ IrqType::Legacy => bindings::PCI_IRQ_INTX,
+ IrqType::Msi => bindings::PCI_IRQ_MSI,
+ IrqType::MsiX => bindings::PCI_IRQ_MSIX,
+ }
+ }
+}
+
+/// Set of IRQ types that can be used for PCI interrupt allocation.
+#[derive(Debug, Clone, Copy, Default)]
+pub struct IrqTypes(u32);
+
+impl IrqTypes {
+ /// Create a set containing all IRQ types (MSI-X, MSI, and Legacy)
+ pub const fn all() -> Self {
+ Self(bindings::PCI_IRQ_ALL_TYPES)
+ }
+
+ /// Add a single IRQ type to the set
+ ///
+ /// # Examples
+ ///
+ /// ```
+ /// // Create a set with only MSI and MSI-X (no legacy interrupts)
+ /// let msi_only = IrqTypes::default()
+ /// .with(IrqType::Msi)
+ /// .with(IrqType::MsiX);
+ /// ```
+ pub const fn with(mut self, irq_type: IrqType) -> Self {
+ self.0 |= irq_type.to_flags();
+ self
+ }
+
+ /// Get the raw flags value
+ const fn raw(self) -> u32 {
+ self.0
+ }
+}
+
/// An adapter for the registration of PCI drivers.
pub struct Adapter<T: Driver>(T);
@@ -413,6 +466,16 @@ pub fn resource_len(&self, bar: u32) -> Result<bindings::resource_size_t> {
}
impl Device<device::Bound> {
+ /// Free all allocated IRQ vectors for this device.
+ ///
+ /// This should be called to release interrupt resources when they are no longer needed,
+ /// during driver unbind or removal.
+ pub fn free_irq_vectors(&self) {
+ // SAFETY: `self.as_raw` is guaranteed to be a pointer to a valid `struct pci_dev`.
+ // `pci_free_irq_vectors` is safe to call even if no vectors are currently allocated.
+ unsafe { bindings::pci_free_irq_vectors(self.as_raw()) };
+ }
+
/// Mapps an entire PCI-BAR after performing a region-request on it. I/O operation bound checks
/// can be performed on compile time for offsets (plus the requested type size) < SIZE.
pub fn iomap_region_sized<'a, const SIZE: usize>(
@@ -445,6 +508,74 @@ pub fn set_master(&self) {
// SAFETY: `self.as_raw` is guaranteed to be a pointer to a valid `struct pci_dev`.
unsafe { bindings::pci_set_master(self.as_raw()) };
}
+
+ /// Allocate IRQ vectors for this PCI device.
+ ///
+ /// Allocates between `min_vecs` and `max_vecs` interrupt vectors for the device.
+ /// The allocation will use MSI-X, MSI, or legacy interrupts based on the `irq_types`
+ /// parameter and hardware capabilities. When multiple types are specified, the kernel
+ /// will try them in order of preference: MSI-X first, then MSI, then legacy interrupts.
+ /// This is called during driver probe.
+ ///
+ /// # Arguments
+ ///
+ /// * `min_vecs` - Minimum number of vectors required
+ /// * `max_vecs` - Maximum number of vectors to allocate
+ /// * `irq_types` - Types of interrupts that can be used
+ ///
+ /// # Returns
+ ///
+ /// Returns the number of vectors successfully allocated, or an error if the allocation
+ /// fails or cannot meet the minimum requirement.
+ ///
+ /// # Examples
+ ///
+ /// ```
+ /// // Allocate using any available interrupt type in the order mentioned above.
+ /// let nvecs = dev.alloc_irq_vectors(1, 32, IrqTypes::all())?;
+ ///
+ /// // Allocate MSI or MSI-X only (no legacy interrupts)
+ /// let msi_only = IrqTypes::default()
+ /// .with(IrqType::Msi)
+ /// .with(IrqType::MsiX);
+ /// let nvecs = dev.alloc_irq_vectors(4, 16, msi_only)?;
+ /// ```
+ pub fn alloc_irq_vectors(
+ &self,
+ min_vecs: u32,
+ max_vecs: u32,
+ irq_types: IrqTypes,
+ ) -> Result<u32> {
+ // SAFETY: `self.as_raw` is guaranteed to be a pointer to a valid `struct pci_dev`.
+ // `pci_alloc_irq_vectors` internally validates all parameters and returns error codes.
+ let ret = unsafe {
+ bindings::pci_alloc_irq_vectors(self.as_raw(), min_vecs, max_vecs, irq_types.raw())
+ };
+
+ to_result(ret)?;
+ Ok(ret as u32)
+ }
+
+ /// Get the Linux IRQ number for a specific vector.
+ ///
+ /// This is called during driver probe after successful IRQ allocation
+ /// to obtain the IRQ numbers for registering interrupt handlers.
+ ///
+ /// # Arguments
+ ///
+ /// * `vector` - The vector index (0-based)
+ ///
+ /// # Returns
+ ///
+ /// Returns the Linux IRQ number for the specified vector, or an error if the vector
+ /// index is invalid or no vectors are allocated.
+ pub fn irq_vector(&self, vector: u32) -> Result<u32> {
+ // SAFETY: `self.as_raw` is guaranteed to be a pointer to a valid `struct pci_dev`.
+ let irq = unsafe { bindings::pci_irq_vector(self.as_raw(), vector) };
+
+ to_result(irq)?;
+ Ok(irq as u32)
+ }
}
// SAFETY: `Device` is a transparent wrapper of a type that doesn't depend on `Device`'s generic
--
2.34.1
next reply other threads:[~2025-09-10 3:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 3:54 Joel Fernandes [this message]
2025-09-10 8:47 ` [PATCH] rust: pci: add PCI interrupt allocation and management support Danilo Krummrich
2025-09-10 18:09 ` Joel Fernandes
2025-09-10 19:02 ` Joel Fernandes
2025-09-15 9:48 ` Danilo Krummrich
2025-09-17 11:09 ` Joel Fernandes
2025-09-12 6:41 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250910035415.381753-1-joelagnelf@nvidia.com \
--to=joelagnelf@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joel@joelfernandes.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox