From: Chris Li <chrisl@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>, Len Brown <lenb@kernel.org>,
Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-acpi@vger.kernel.org, David Matlack <dmatlack@google.com>,
Pasha Tatashin <tatashin@google.com>,
Jason Miu <jasonmiu@google.com>,
Vipin Sharma <vipinsh@google.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Adithya Jayachandran <ajayachandra@nvidia.com>,
Parav Pandit <parav@nvidia.com>, William Tu <witu@nvidia.com>,
Mike Rapoport <rppt@kernel.org>, Chris Li <chrisl@kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
Leon Romanovsky <leon@kernel.org>
Subject: [PATCH v2 05/10] PCI/LUO: Forward finish callbacks to drivers
Date: Tue, 16 Sep 2025 00:45:13 -0700 [thread overview]
Message-ID: <20250916-luo-pci-v2-5-c494053c3c08@kernel.org> (raw)
In-Reply-To: <20250916-luo-pci-v2-0-c494053c3c08@kernel.org>
When PCI receives the LUO finish callback. The PCI subsystem forwards the
finish callback to the driver with restored dev->lu.dev_state->data.
Tested: In qemu, request a virtio net device as requested.
Perform luo prepare then kexec. Verify the new kernel boot up
dmesg shows the requested device has per device live update state
restored. Perform liveupdate finish and see the device finish
callback gets invoked.
Signed-off-by: Chris Li <chrisl@kernel.org>
---
drivers/pci/liveupdate.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/drivers/pci/liveupdate.c b/drivers/pci/liveupdate.c
index 305c5e85aba6bac9d02f97c83e7b3250298d2eff..41606df346f751c78f6c69caa275b4a76be72510 100644
--- a/drivers/pci/liveupdate.c
+++ b/drivers/pci/liveupdate.c
@@ -264,6 +264,29 @@ static int pci_call_freeze(struct pci_ser *pci_state, struct list_head *devlist)
return 0;
}
+static void pci_call_finish(struct list_head *devlist)
+{
+ struct device *dev;
+
+ pci_lock_rescan_remove();
+ down_write(&pci_bus_sem);
+
+ list_for_each_entry(dev, devlist, lu.lu_next) {
+ struct pci_dev_ser *s = dev->lu.dev_state;
+
+ if (!dev->driver)
+ panic("PCI luo finish: dev %s does not have driver", dev_name(dev));
+ if (!dev->driver->lu)
+ panic("PCI luo finish: dev %s does not support liveupdate",
+ dev_name(dev));
+ if (!dev->driver->lu->finish)
+ continue;
+ dev->driver->lu->finish(dev, s->driver_data);
+ }
+ up_write(&pci_bus_sem);
+ pci_unlock_rescan_remove();
+}
+
static int pci_liveupdate_freeze(void *arg, u64 *data)
{
struct pci_ser *pci_state = phys_to_virt(*data);
@@ -297,7 +320,12 @@ static void pci_liveupdate_cancel(void *arg, u64 data)
static void pci_liveupdate_finish(void *arg, u64 data)
{
+ struct pci_ser *pci_state = phys_to_virt(data);
+
pr_info("finish data[%llx]\n", data);
+ pci_call_finish(&probe_devices);
+ cleanup_liveupdate_devices(&probe_devices);
+ cleanup_liveupdate_state(pci_state);
}
struct liveupdate_subsystem pci_liveupdate_ops = {
--
2.51.0.384.g4c02a37b29-goog
next prev parent reply other threads:[~2025-09-16 7:45 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 7:45 [PATCH v2 00/10] LUO: PCI subsystem (phase I) Chris Li
2025-09-16 7:45 ` [PATCH v2 01/10] PCI/LUO: Register with Liveupdate Orchestrator Chris Li
2025-09-30 15:15 ` Greg Kroah-Hartman
2025-09-30 23:41 ` Chris Li
2025-09-30 15:17 ` Greg Kroah-Hartman
2025-09-30 23:38 ` Chris Li
2025-09-16 7:45 ` [PATCH v2 02/10] PCI/LUO: Create requested liveupdate device list Chris Li
2025-09-29 17:46 ` Jason Gunthorpe
2025-09-30 2:13 ` Chris Li
2025-09-30 16:47 ` Jason Gunthorpe
2025-10-03 7:09 ` Chris Li
2025-10-03 5:33 ` Chris Li
2025-10-03 14:04 ` Jason Gunthorpe
2025-10-03 21:06 ` Chris Li
2025-09-30 15:26 ` Greg Kroah-Hartman
2025-10-03 6:57 ` Chris Li
2025-09-16 7:45 ` [PATCH v2 03/10] PCI/LUO: Forward prepare()/freeze()/cancel() callbacks to driver Chris Li
2025-09-29 17:48 ` Jason Gunthorpe
2025-09-30 2:11 ` Chris Li
2025-09-30 16:38 ` Jason Gunthorpe
2025-10-02 18:54 ` David Matlack
2025-10-02 20:57 ` Chris Li
2025-10-02 21:31 ` David Matlack
2025-10-02 23:21 ` Jason Gunthorpe
2025-10-02 23:42 ` David Matlack
2025-10-03 12:03 ` Jason Gunthorpe
2025-10-03 16:03 ` David Matlack
2025-10-03 16:16 ` Jason Gunthorpe
2025-10-03 16:28 ` Pasha Tatashin
2025-10-03 16:56 ` David Matlack
2025-10-03 5:24 ` Chris Li
2025-10-03 12:06 ` Jason Gunthorpe
2025-10-03 16:27 ` David Matlack
2025-10-03 16:41 ` Vipin Sharma
2025-10-03 17:44 ` Chris Li
2025-10-03 5:17 ` Chris Li
2025-10-02 20:44 ` Chris Li
2025-09-30 15:27 ` Greg Kroah-Hartman
2025-10-02 20:38 ` Chris Li
2025-10-03 6:18 ` Greg Kroah-Hartman
2025-10-03 7:26 ` Chris Li
2025-10-03 12:26 ` Greg Kroah-Hartman
2025-10-03 17:49 ` Chris Li
2025-10-03 18:27 ` David Matlack
2025-10-03 21:10 ` Chris Li
2025-09-16 7:45 ` [PATCH v2 04/10] PCI/LUO: Restore state at PCI enumeration Chris Li
2025-09-16 7:45 ` Chris Li [this message]
2025-09-16 7:45 ` [PATCH v2 06/10] PCI/LUO: Save and restore driver name Chris Li
2025-09-29 17:57 ` Jason Gunthorpe
2025-09-30 2:10 ` Chris Li
2025-09-30 13:02 ` Pasha Tatashin
2025-09-30 13:41 ` Greg Kroah-Hartman
2025-09-30 14:53 ` Pasha Tatashin
2025-09-30 15:08 ` Greg Kroah-Hartman
2025-09-30 15:56 ` Pasha Tatashin
2025-10-01 5:06 ` Greg Kroah-Hartman
2025-10-01 21:03 ` Pasha Tatashin
2025-10-02 6:09 ` Greg Kroah-Hartman
2025-10-02 13:23 ` Jason Gunthorpe
2025-10-02 22:30 ` Chris Li
2025-09-30 15:41 ` Chris Li
2025-10-01 5:13 ` Greg Kroah-Hartman
2025-10-02 22:05 ` Chris Li
2025-09-30 16:37 ` Jason Gunthorpe
2025-10-02 21:39 ` Chris Li
2025-10-03 14:28 ` Jason Gunthorpe
2025-09-16 7:45 ` [PATCH v2 07/10] PCI/LUO: Add liveupdate to pcieport driver Chris Li
2025-09-16 7:45 ` [PATCH v2 08/10] PCI/LUO: Add pci_liveupdate_get_driver_data() Chris Li
2025-09-16 7:45 ` [PATCH v2 09/10] PCI/LUO: Avoid write to bus master at boot Chris Li
2025-09-29 17:14 ` Bjorn Helgaas
2025-09-16 7:45 ` [PATCH v2 10/10] PCI: pci-lu-stub: Add a stub driver for Live Update testing Chris Li
2025-09-27 17:13 ` [PATCH v2 00/10] LUO: PCI subsystem (phase I) Bjorn Helgaas
2025-09-27 18:05 ` Pasha Tatashin
2025-09-29 15:04 ` Bjorn Helgaas
2025-09-29 18:13 ` Chris Li
2025-10-07 23:32 ` Chris Li
2025-10-08 23:00 ` David Matlack
2025-10-09 17:12 ` Chris Li
2025-10-09 23:21 ` Pratyush Yadav
2025-10-10 4:19 ` Chris Li
2025-10-10 23:49 ` Jason Miu
2025-10-13 13:58 ` Pratyush Yadav
2025-10-14 16:11 ` Pratyush Yadav
2025-10-14 20:44 ` Chris Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250916-luo-pci-v2-5-c494053c3c08@kernel.org \
--to=chrisl@kernel.org \
--cc=ajayachandra@nvidia.com \
--cc=bhelgaas@google.com \
--cc=dakr@kernel.org \
--cc=dmatlack@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jasonmiu@google.com \
--cc=jgg@ziepe.ca \
--cc=lenb@kernel.org \
--cc=leon@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=pasha.tatashin@soleen.com \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tatashin@google.com \
--cc=vipinsh@google.com \
--cc=witu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).