From: Jason Gunthorpe <jgg@ziepe.ca>
To: manivannan.sadhasivam@oss.qualcomm.com
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Joerg Roedel <jroedel@suse.de>,
iommu@lists.linux.dev, Anders Roxell <anders.roxell@linaro.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Pavankumar Kondeti <quic_pkondeti@quicinc.com>,
Xingang Wang <wangxingang5@huawei.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 0/2] PCI: Fix ACS enablement for Root Ports in DT platforms
Date: Thu, 18 Sep 2025 11:11:02 -0300 [thread overview]
Message-ID: <20250918141102.GO1326709@ziepe.ca> (raw)
In-Reply-To: <20250910-pci-acs-v1-0-fe9adb65ad7d@oss.qualcomm.com>
On Wed, Sep 10, 2025 at 11:09:19PM +0530, Manivannan Sadhasivam via B4 Relay wrote:
> This issue was already found and addressed with a quirk for a different device
> from Microsemi with 'commit, aa667c6408d2 ("PCI: Workaround IDT switch ACS
> Source Validation erratum")'. Apparently, this issue seems to be documented in
> the erratum #36 of IDT 89H32H8G3-YC, which is not publicly available.
This is a pretty broken device! I'm not sure this fix is good enough
though.
For instance if you reset a downstream device it should loose its RID
and then the config cycles waiting for reset to complete will trigger SV
and reset will fail?
Maybe a better answer is to say these switches don't support SV and
prevent the kernel from enabling it in the first place?
Jason
next prev parent reply other threads:[~2025-09-18 14:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 17:39 [PATCH 0/2] PCI: Fix ACS enablement for Root Ports in DT platforms Manivannan Sadhasivam via B4 Relay
2025-09-10 17:39 ` [PATCH 1/2] PCI: Extend pci_idt_bus_quirk() for IDT switch with Device ID 0x8090 Manivannan Sadhasivam via B4 Relay
2025-09-10 17:39 ` [PATCH 2/2] iommu/of: Call pci_request_acs() before enumerating the Root Port device Manivannan Sadhasivam via B4 Relay
2025-09-23 20:27 ` Bjorn Helgaas
2025-09-24 8:50 ` Manivannan Sadhasivam
2025-09-24 18:57 ` Bjorn Helgaas
2025-09-24 19:49 ` Robin Murphy
2025-10-04 17:34 ` Manivannan Sadhasivam
2025-09-11 17:44 ` [PATCH 0/2] PCI: Fix ACS enablement for Root Ports in DT platforms Naresh Kamboju
2025-09-18 14:11 ` Jason Gunthorpe [this message]
2025-09-23 15:37 ` Manivannan Sadhasivam
2025-09-23 16:21 ` Jason Gunthorpe
2025-09-24 8:21 ` Manivannan Sadhasivam
2025-09-24 12:55 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250918141102.GO1326709@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=anders.roxell@linaro.org \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=naresh.kamboju@linaro.org \
--cc=quic_pkondeti@quicinc.com \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=wangxingang5@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox